Include TckBase.class in application archives where test class extends TckBase #159
Conversation
During running of TCK, it was found that for test classes that extended TckBase and did not include the TckBase class in the Archive file would throw ClassNotFoundException TckBase Use the the getBaseArchive Method and add explicitly needed classes to the the archive during deployment.
|
Can one of the admins verify this patch? |
|
@eclipse-microprofile-bot test this please |
|
This is the same problem that we've fixed before in #56. It looks like the tests fixed in this PR are new ones added since 1.0. |
|
In case it's not clear, this is a TCK challenge. The tests are broken and cannot be run in a remote or managed arquillian container. |
|
The build is failing with the following error: This appears to be because the Jenkins instance has been updated to a version which requires Java 11 and the maven integration plugin requires that the build is run with a version of Java which is at least as high as that required by Jenkins. I'll update the build definition to run with Java 11. |
|
@eclipse-microprofile-bot test this please |
|
The build now fails because the version of We should update to the latest 2.x version of the microprofile-parent pom to update our plugins and dependencies. I'll open another PR to do this. Opened #160 |
|
With #160 merged, let's try again @eclipse-microprofile-bot test this please |
|
Builds are now passing and I've tested this change with #160 on both Open Liberty and smallrye-reactive-messaging. |
During running of the 3.0 TCK. It was found that for a number of the newer test classes that extended TckBase, did not include the TckBase class in the application archive would throw ClassNotFoundException TckBase when run on Open Liberty.
Use the
getBaseArchive()to include base classes and configuration and only add the additional classes for those tests.All the affected tests use the same ServiceLoader and manifest resource as defined in
getBaseArchive()