Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update microprofile-parent version #177

Merged
merged 2 commits into from Sep 8, 2023
Merged

Conversation

tevans78
Copy link
Contributor

@tevans78 tevans78 commented Aug 3, 2023

The main aim of this PR is to update the version of microprofile-parent to 2.8. This also has the effect of updating the version of TestNG to 7.5.1. The Arquillian runner ReactiveStreamsArquillianTck was using some TestNG internals which have now been moved. So instead of using internals, we have changed to using just APIs.

The version of the frontend-maven-plugin has also been updated to one which works on an M1 Mac.
Rebuilding with the new microprofile-parent version has also resulted in some minor changes to javadoc in a couple of API classes.

Signed-off-by: Tom Evans <tevans@uk.ibm.com>
@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

@Azquelt
Copy link
Member

Azquelt commented Aug 3, 2023

@eclipse-microprofile-bot test this please

1 similar comment
@Azquelt
Copy link
Member

Azquelt commented Aug 3, 2023

@eclipse-microprofile-bot test this please

@Azquelt
Copy link
Member

Azquelt commented Aug 3, 2023

The updated parent pom needs Java 11 to build. We've updated the CI build to use Java 11 so hopefully a rebuild will succeed this time.

We should still be targeting Java 8 for the built classes.

Signed-off-by: Tom Evans <tevans@uk.ibm.com>
@tevans78
Copy link
Contributor Author

tevans78 commented Aug 3, 2023

@eclipse-microprofile-bot test this please

1 similar comment
@Azquelt
Copy link
Member

Azquelt commented Aug 15, 2023

@eclipse-microprofile-bot test this please

@Azquelt
Copy link
Member

Azquelt commented Sep 6, 2023

@cescoffier Do you have any objection to this? It mostly just updates our test dependencies, so that we have newer versions of TestNG and Arquillian which work with the latest versions of Jakarta EE and don't have known security issues.

@Azquelt
Copy link
Member

Azquelt commented Sep 7, 2023

After looking at this further for the PRs on reactive messaging, we also need the plugin updates that the newer version of the parent brings in to work correctly on the latest versions of maven which the Eclipse CI is configured to use.

@Azquelt Azquelt merged commit 249bc47 into eclipse:main Sep 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants