Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace javax namespace usage with jakarta and align with Microprofile 6.0 #352

Closed
wants to merge 1 commit into from

Conversation

reta
Copy link

@reta reta commented Jan 14, 2023

The Microprofile 6.0 is out and aligns with Jakarta EE 10 Core Profile. It still bundles MicroProfile Rest Client 3.0 [1] but the minimum Java SE version now is Java SE 11 or higher [2]. With that in mind, we could fix the remaining javax.* -> jakarta.* by updating to Wiremock 3.0.0 (which uses Jetty 11).

Closes #346

[1] https://github.com/eclipse/microprofile/releases/tag/6.0
[2] https://jakarta.ee/specifications/coreprofile/10/

Signed-off-by: Andriy Redko <drreta@gmail.com>
Copy link
Contributor

@andymc12 andymc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but I'd like somebody from the strategic implementers (RedHat, IBM, Payara, etc.) to review it before merging. I'll add some folks for review. Thanks @reta!

@michalszynkiewicz
Copy link
Contributor

hey @andymc12 , I'm no longer at RH

@andymc12
Copy link
Contributor

hey @andymc12 , I'm no longer at RH

Thanks for letting me know - and congrats on your new job! I tagged Pavol for RH's review instead.

@Emily-Jiang
Copy link
Member

This spec do not need to be updated to align with Jakarta EE 10 Core Profile as it should work with Jakarta EE 9.1 or EE 10.

@reta
Copy link
Author

reta commented Jan 25, 2023

This spec do not need to be updated to align with Jakarta EE 10 Core Profile as it should work with Jakarta EE 9.1 or EE 10.

Fair enough, the TCK seems to be stuck in own reality, due to dependency choices, and still uses javax.*. Should the TCK be rewritten then?

@Emily-Jiang
Copy link
Member

This spec do not need to be updated to align with Jakarta EE 10 Core Profile as it should work with Jakarta EE 9.1 or EE 10.

Fair enough, the TCK seems to be stuck in own reality, due to dependency choices, and still uses javax.*. Should the TCK be rewritten then?

The update of Wiremock 3.0.0 (which uses Jetty 11) can be done. Many runtimes certified this TCK for MP 5.0 without any issues though.

@reta
Copy link
Author

reta commented Jan 25, 2023

This spec do not need to be updated to align with Jakarta EE 10 Core Profile as it should work with Jakarta EE 9.1 or EE 10.

Fair enough, the TCK seems to be stuck in own reality, due to dependency choices, and still uses javax.*. Should the TCK be rewritten then?

The update of Wiremock 3.0.0 (which uses Jetty 11) can be done.

Wiremock 3 / Jetty 11 needs JDK 11 (this pull request)

Many runtimes certified this TCK for MP 5.0 without any issues though.

The workarounds exist to make it work, but that is not sustainable to be fair

@Emily-Jiang
Copy link
Member

#360 superseded this. I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace javax namespace usage with jakarta
4 participants