Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #2

Merged
merged 13 commits into from Oct 23, 2017
Merged

Master #2

merged 13 commits into from Oct 23, 2017

Conversation

mmusgrov
Copy link
Contributor

@mmusgrov mmusgrov commented Oct 16, 2017

This PR is a proposal for supporting "Consistency Models for Microservices". The actual proposal is:
https://github.com/eclipse/microprofile-sandbox/pull/2/files#diff-eeb2668147f799967ab5923f47f739a3

The TCK uses Arquilian to start up the two microservices (the LRA coordinator and test service) and is in our project repo: https://github.com/jbosstm/narayana/tree/master/rts/lra/lra-test

@mmusgrov
Copy link
Contributor Author

mmusgrov commented Oct 17, 2017

@mikecroft I have asked each committer to sign the ECA.
As to the "Signed-Off-By (git commit -s)" failure:

  • would it be acceptable for me to raise a commit using the -S flag and then ensure that all future commits are signed;
  • or do you need me to collapse all the commits and sign that single commit;
  • or do you have a recommendation.

@mikecroft
Copy link
Member

@mmusgrov this could be tricky. I believe everyone in the list will need to amend at least the latest commit (AFAIK - it may need to be every commit from them).

The added complication is that somewhere someone has used GitHub to commit a change so the noreply@github.com email is being picked up. There is an open Bugzilla ticket to address that, but other than it being accepted as a bug of the process there is no word on when that will be resolved.

In case the validator does need every commit to be signed, I'm sure you could squash your own commits without any issue, but I don't think other people's contributions could be since it would probably run in to trouble when doing the next IP review.

@mikecroft
Copy link
Member

It's not 100% clear, but this document does suggest that every commit needs to be signed off:
https://wiki.eclipse.org/Development_Resources/Contributing_via_Git

It's literally just a string in the commit message, so if you could find a nice way with some Git tool to edit those manually, I'm sure that would work.

mmusgrov and others added 13 commits October 17, 2017 15:47
0009-LRA Proposed CDI annotations

Include support for JTA style transactions

Signed-off-by: Michael Musgrove <mmusgrov@redhat.com>
Removed some text

WS-LRA was not SOAP specific so I don't quite get the REST quote. Plus, why not just us JFDI?

Signed-off-by: Mark Little <mlittle@redhat.com>
Formalise LRAStatus using JSON

Signed-off-by: Michael Musgrove <mmusgrov@redhat.com>
Fixing numbering

Typo

Signed-off-by: Nicola Ferraro <ni.ferraro@gmail.com>
Http statuses specified with the code

Using term 'query string' instead of 'qualifiers'

fixing inner link to cdi annotation section

Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>
Signed-off-by: Tom Jenkinson <tom.jenkinson@redhat.com>
Renaming headers in all places

Signed-off-by: Nicola Ferraro <ni.ferraro@gmail.com>
Signed-off-by: Michael Musgrove <mmusgrov@redhat.com>
show text description on following line

allow for unavailable participant

forget participant via forget url

Use rollback on for SRA

Updated the SRA sequence diagram

Removed TODO statement

Signed-off-by: Tom Jenkinson <tom.jenkinson@redhat.com>
0009-LRA Fix broken links

Signed-off-by: Michael Musgrove <mmusgrov@redhat.com>
when reading the spec I was misguided by the jax-rs endpoint naming.
The word 'complete' is used as compensator handler naming and
this example shows on starting and ending LRA by end.
I think it should not use the same naming.

Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>

formatting changes

Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>
Signed-off-by: Michael Musgrove <mmusgrov@redhat.com>
@mikecroft
Copy link
Member

Since all IP checks have passed, I'll merge this based on "Step 0" in the process outlining this as a "merge first, fix later" repository.
https://wiki.eclipse.org/MicroProfile/FeatureInit

It looks like John requested a change, but this should be made in further PRs

Ideally all source files would have a common license header. https://github.com/eclipse/microprofile-jwt-auth/blob/master/spec/src/main/asciidoc/license-alv2.asciidoc can be used as an example.

@mikecroft mikecroft merged commit cdceb42 into eclipse:master Oct 23, 2017
@mmusgrov
Copy link
Contributor Author

Thanks. I will be separately address issues as they come up in new PRs.

chyt pushed a commit to chyt/microprofile-sandbox that referenced this pull request Jun 3, 2019
chyt pushed a commit to chyt/microprofile-sandbox that referenced this pull request Jun 3, 2019
Update internal boost-common dependencies, gradle->0.1.2, maven->0.1.…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants