Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use display name for Server dropdown. #39

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Use display name for Server dropdown. #39

merged 1 commit into from
Jan 22, 2019

Conversation

rdebusscher
Copy link
Member

No description provided.

@rdebusscher rdebusscher added this to the 0.8 milestone Jan 22, 2019
@rdebusscher rdebusscher self-assigned this Jan 22, 2019
@rdebusscher rdebusscher mentioned this pull request Jan 22, 2019
Closed
Emily-Jiang
Emily-Jiang approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was not sure whether my change will work as it contains space. With your current change, the list will be better displayed.

@rdebusscher rdebusscher merged commit c5475f3 into eclipse:master Jan 22, 2019
@rdebusscher rdebusscher mentioned this pull request Jan 22, 2019
Closed
@rdebusscher rdebusscher deleted the display-name branch January 22, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emily-Jiang Emily-Jiang Emily-Jiang approved these changes

Assignees

@rdebusscher rdebusscher

Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdebusscher @Emily-Jiang