Parameter and error tests #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azquelt
reviewed
Aug 10, 2023
.../java/org/eclipse/microprofile/telemetry/tracing/tck/async/JaxRsClientAsyncTestEndpoint.java
Outdated
Show resolved
Hide resolved
Azquelt
reviewed
Aug 10, 2023
...src/main/java/org/eclipse/microprofile/telemetry/tracing/tck/async/JaxRsClientAsyncTest.java
Outdated
Show resolved
Hide resolved
yasmin-aumeeruddy
force-pushed
the
parameter-and-error-tests
branch
3 times, most recently
from
f6c3341
to
9e7ea72
Compare
yasmin-aumeeruddy
force-pushed
the
parameter-and-error-tests
branch
from
9e7ea72
to
648f1e9
Compare
Azquelt
requested changes
Aug 10, 2023
...src/main/java/org/eclipse/microprofile/telemetry/tracing/tck/async/JaxRsServerAsyncTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/microprofile/telemetry/tracing/tck/async/JaxRsServerAsyncTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/microprofile/telemetry/tracing/tck/async/JaxRsServerAsyncTest.java
Outdated
Show resolved
Hide resolved
.../java/org/eclipse/microprofile/telemetry/tracing/tck/async/JaxRsServerAsyncTestEndpoint.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/microprofile/telemetry/tracing/tck/async/JaxRsServerAsyncTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/eclipse/microprofile/telemetry/tracing/tck/async/MpRestClientAsyncTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/eclipse/microprofile/telemetry/tracing/tck/async/MpRestClientAsyncTest.java
Show resolved
Hide resolved
Azquelt
reviewed
Aug 11, 2023
.../java/org/eclipse/microprofile/telemetry/tracing/tck/async/JaxRsClientAsyncTestEndpoint.java
Outdated
Show resolved
Hide resolved
- Code review comments - Change expected response code to Bad Request (400) so that we can distinguish between the expected error code and an error code generated by an unexpected exception
|
After checking with Yasmin, I've pushed up changes for the comments I raised. |
Azquelt
force-pushed
the
parameter-and-error-tests
branch
from
6bded1d
to
cc80b3c
Compare
|
I realised while I was testing that the arguments to |
Azquelt
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test query parameters and errors with the async tests