Chapter 5: MicroProfile Configuration #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Understanding MicroProfile Configuration Different environments required for Microservices development Working with Various Configuration Sources Key capabilities of MicroProfile Configuration
Adding first 4 sections to chapter05.adoc
|
I am reviewing this PR and will provide feedback asap. |
|
Awaiting review feedback and approval. |
Emily-Jiang
reviewed
Apr 9, 2024
Emily-Jiang
reviewed
Apr 15, 2024
Emily-Jiang
reviewed
Apr 15, 2024
Emily-Jiang
reviewed
Apr 15, 2024
| private boolean maintenanceMode; | ||
| ---- | ||
|
|
||
| In this example, the `product.maintenanceMode` property will be converted to an `Boolean` before it is injected into the `maintenanceMode` field. If the conversion fails, a `org.eclipse.microprofile.config.ConversionFailedException` will be thrown. |
There was a problem hiding this comment.
The exception does not exist though.
Emily-Jiang
reviewed
Apr 15, 2024
| } | ||
| ---- | ||
|
|
||
| In this example, we’re injecting a property named "product.maintenanceMessage" into the message field of our MaintenanceMessage class. If the property does not exist, a `org.eclipse.microprofile.config.ConfigPropertyNotFoundException` will be thrown. |
There was a problem hiding this comment.
The exception does not exist.
There was a problem hiding this comment.
I still see this exception on the line 325.
Emily-Jiang
reviewed
Apr 15, 2024
Emily-Jiang
reviewed
Apr 15, 2024
Emily-Jiang
reviewed
Apr 15, 2024
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
Minor grammar fixes
|
@ttelang please comment here after you have addressed all of the comments |
|
I have addressed all of the comments. @Emily-Jiang - Kindly merge this PR |
I double checked and found 2 comments were not resolved. Please address them. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Chapter 5 about MicroProfile Configuration