Allow global and per-session max Subscriptions to be configured

eclipse · Aug 24, 2022 · 938ed51 · 938ed51
1 parent 4534381
commit 938ed51
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/...r/src/main/java/org/eclipse/milo/opcua/sdk/server/api/config/OpcUaServerConfigLimits.java b/...r/src/main/java/org/eclipse/milo/opcua/sdk/server/api/config/OpcUaServerConfigLimits.java
@@ -90,6 +90,24 @@ default Double getMaxSubscriptionLifetime() {
         return (double) TimeUnit.MILLISECONDS.convert(24, TimeUnit.HOURS);
     }
 
+    /**
+     * Get the maximum number of Subscriptions, across all Sessions, that can be created.
+     *
+     * @return the maximum number of Subscriptions, across all Sessions, that can be created.
+     */
+    default UInteger getMaxSubscriptions() {
+        return uint(Integer.MAX_VALUE);
+    }
+
+    /**
+     * Get the maximum number of Subscriptions, per Session, that can be created.
+     *
+     * @return the maximum number of Subscriptions, per Session, that can be created.
+     */
+    default UInteger getMaxSubscriptionsPerSession() {
+        return uint(Integer.MAX_VALUE);
+    }
+
     default Double getMaxSupportedSampleRate() {
         return (double) TimeUnit.MILLISECONDS.convert(24, TimeUnit.HOURS);
     }

diff --git a/...er/src/main/java/org/eclipse/milo/opcua/sdk/server/subscriptions/SubscriptionManager.java b/...er/src/main/java/org/eclipse/milo/opcua/sdk/server/subscriptions/SubscriptionManager.java
@@ -156,6 +156,16 @@ public List<Subscription> getSubscriptions() {
     public void createSubscription(ServiceRequest service) {
         CreateSubscriptionRequest request = (CreateSubscriptionRequest) service.getRequest();
 
+        if (subscriptions.size() >= server.getConfig().getLimits().getMaxSubscriptionsPerSession().intValue()) {
+            service.setServiceFault(StatusCodes.Bad_TooManySubscriptions);
+            return;
+        }
+
+        if (server.getSubscriptions().size() >= server.getConfig().getLimits().getMaxSubscriptions().intValue()) {
+            service.setServiceFault(StatusCodes.Bad_TooManySubscriptions);
+            return;
+        }
+
         UInteger subscriptionId = nextSubscriptionId();
 
         Subscription subscription = new Subscription(
@@ -204,7 +214,8 @@ public void createSubscription(ServiceRequest service) {
         ResponseHeader header = service.createResponseHeader();
 
         CreateSubscriptionResponse response = new CreateSubscriptionResponse(
-            header, subscriptionId,
+            header,
+            subscriptionId,
             subscription.getPublishingInterval(),
             uint(subscription.getLifetimeCount()),
             uint(subscription.getMaxKeepAliveCount())