Fix ADC reference voltage and expose BSP_ExtensionPort_Connect() #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
reviewed
Oct 29, 2018
| * } | ||
| * @endcode | ||
| */ | ||
| export native unchecked fn BSP_ExtensionPort_Connect(): int32 header "BSP_ExtensionPort.h"; |
There was a problem hiding this comment.
Not sure if this what we want ... should controlling the extension bus not rather be part of a resource configuration?
There was a problem hiding this comment.
Well, in some cases you just want to provide power to something external. We could make some kind of setup externalPower { enable2v5 = true; } though.
|
@tkutz @rherrmannr Please check that this doesn't break the arduino implementation :) |
|
@wegendt-bosch it's still working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.