Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test, "WITH_TLS_PSK=no" executes 08-tls-psk* tests #636

Closed
TBK opened this issue Dec 2, 2017 · 1 comment
Closed

Make test, "WITH_TLS_PSK=no" executes 08-tls-psk* tests #636

TBK opened this issue Dec 2, 2017 · 1 comment
Assignees
@ralight
Labels
Component: build Related to the Makefiles / build scripts in the project. Type: Bug
Milestone
fixes-next

Comments

@TBK
Copy link

TBK commented Dec 2, 2017

When Mosquitto is build with the WITH_TLS_PSK flag set to no, then the tests for TLS PSK are still run.

The following patch should fix the issue:

--- a/test/broker/Makefile
+++ b/test/broker/Makefile
@@ -89,8 +89,10 @@
 	./08-ssl-connect-identity.py
 	./08-ssl-connect-no-identity.py
 	./08-ssl-bridge.py
+ifeq ($(WITH_TLS_PSK),yes)
 	./08-tls-psk-pub.py
 	./08-tls-psk-bridge.py
+endif
 endif
 
 09 :
@ralight ralight added this to the fixes-next milestone Dec 3, 2017
@ralight ralight added Type: Bug Component: build Related to the Makefiles / build scripts in the project. labels Dec 3, 2017
@ralight ralight self-assigned this Dec 3, 2017
ralight added a commit that referenced this issue Dec 3, 2017
@ralight
[636] Don't run TLS-PSK tests when disabled at compile time.
d2118ae 
Thanks to 'TBK'.

Bug: #636
@ralight
Copy link
Contributor

ralight commented Dec 3, 2017

Thanks, I've added a fix for this.

@ralight ralight closed this as completed Dec 3, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ralight ralight

Labels
Component: build Related to the Makefiles / build scripts in the project. Type: Bug
Projects
None yet
Milestone
fixes-next
Development

No branches or pull requests
2 participants
@ralight @TBK