Fix usage of tls_engine and tls_keyform. #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that the whole commit? It doesn't quite match up to the comment for me. |
|
Yes, this is it. Some of the engine parameters specified in mosquitto.conf are not making it all the way to where they are being used. |
|
Ok, thanks I'll look at it properly soon. |
The current implementation does not properly forward the engine parameters to OpenSSL causing OpenSSL to incorrectly attempt to open the engine key uri as a file. Sponsored-by: Trimble, Inc. Signed-off-by: Matt Woelfel <matt@woelfware.com>
woelfman
force-pushed
the
fix-engine-key-uri
branch
from
be7dd38
to
39803e5
Compare
|
Thanks very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not properly forward the engine
parameters to OpenSSL causing OpenSSL to incorrectly attempt to open the
engine key uri as a file.
This fix enables net_mosq.c:net__init_ssl_ctx to use ENGINE_load_private_key instead of SSL_CTX_use_PrivateKey_file.
Signed-off-by: Matt Woelfel matt@woelfware.com