Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: mosquitto_ctrl: don't hard set paths #1930

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

karlp
Copy link
Contributor

@karlp karlp commented Dec 4, 2020

In a cross compile environment, these paths will be added elsewhere, and
in a local environment, they should already be covered by the system
compiler. Simply drop them.

Signed-off-by: Karl Palsson karlp@etactica.com

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • [x ] Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • [x ] Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
    no, 2.0 isn't in fixes yet?
  • [x ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

Changes required for OpenWrt packaging at least

In a cross compile environment, these paths will be added elsewhere, and
in a local environment, they should already be covered by the system
compiler.  Simply drop them.

Signed-off-by: Karl Palsson <karlp@etactica.com>
@ralight ralight changed the base branch from master to fixes December 4, 2020 21:59
@ralight
Copy link
Contributor

ralight commented Dec 4, 2020

Thanks Karl.

@ralight ralight merged commit 5679a4d into eclipse:fixes Dec 4, 2020
@karlp
Copy link
Contributor Author

karlp commented Dec 4, 2020

you're very welcome :)

@karlp karlp deleted the crosss-fixes20 branch December 4, 2020 22:07
karlp added a commit to etactica/packages that referenced this pull request Dec 4, 2020
Major release, full release notes available at:
https://mosquitto.org/blog/2020/12/version-2-0-0-released/

Tested on ath79, ssl full, ssl trimmed and non-ssl builds.
Users may/will run into some of the changes in default
authentication.  Note
https://mosquitto.org/documentation/migrating-to-2-0/ for tips on
migrating.

Patch included has already merged upstream, but didn't make the release:
eclipse/mosquitto#1930

Signed-off-by: Karl Palsson <karlp@etactica.com>
karlp added a commit to etactica/packages that referenced this pull request Dec 5, 2020
Major release, full release notes available at:
https://mosquitto.org/blog/2020/12/version-2-0-0-released/

Tested on ath79, ssl full, ssl trimmed and non-ssl builds, and also all
at the same time.
Users may/will run into some of the changes in default
authentication.  Note
https://mosquitto.org/documentation/migrating-to-2-0/ for tips on
migrating.

Patch included has already merged upstream, but didn't make the release:
eclipse/mosquitto#1930

Signed-off-by: Karl Palsson <karlp@etactica.com>
karlp added a commit to etactica/packages that referenced this pull request Dec 5, 2020
Major release, full release notes available at:
https://mosquitto.org/blog/2020/12/version-2-0-0-released/

Tested on ath79, ssl full, ssl trimmed and non-ssl builds, and also all
at the same time.
Users may/will run into some of the changes in default
authentication.  Note
https://mosquitto.org/documentation/migrating-to-2-0/ for tips on
migrating.

Patch included has already merged upstream, but didn't make the release:
eclipse/mosquitto#1930

Signed-off-by: Karl Palsson <karlp@etactica.com>
karlp added a commit to openwrt/packages that referenced this pull request Dec 8, 2020
Major release, full release notes available at:
https://mosquitto.org/blog/2020/12/version-2-0-0-released/

Tested on ath79, ssl full, ssl trimmed and non-ssl builds, and also all
at the same time.
Users may/will run into some of the changes in default
authentication.  Note
https://mosquitto.org/documentation/migrating-to-2-0/ for tips on
migrating.

Patch included has already merged upstream, but didn't make the release:
eclipse/mosquitto#1930

Signed-off-by: Karl Palsson <karlp@etactica.com>
1715173329 pushed a commit to immortalwrt/packages that referenced this pull request Dec 8, 2020
Major release, full release notes available at:
https://mosquitto.org/blog/2020/12/version-2-0-0-released/

Tested on ath79, ssl full, ssl trimmed and non-ssl builds, and also all
at the same time.
Users may/will run into some of the changes in default
authentication.  Note
https://mosquitto.org/documentation/migrating-to-2-0/ for tips on
migrating.

Patch included has already merged upstream, but didn't make the release:
eclipse/mosquitto#1930

Signed-off-by: Karl Palsson <karlp@etactica.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants