Add NetBSD Support #258
Add NetBSD Support #258
Conversation
|
in general, (I'm not a developer or committer here) your commit messages should have somethign useful in them, like, "Support building on NetBSD" rather than the incredibly vague "update file X" "Update file x" is immediately obvious from the diffstat, what's more interesting in the commit comment is the why and how the changes made were done. |
| @@ -115,7 +115,7 @@ LIB_LDFLAGS:=${LDFLAGS} | |||
| BROKER_CFLAGS:=${LIB_CFLAGS} ${CPPFLAGS} -DVERSION="\"${VERSION}\"" -DTIMESTAMP="\"${TIMESTAMP}\"" -DWITH_BROKER | |||
| CLIENT_CFLAGS:=${CFLAGS} ${CPPFLAGS} -I../lib -DVERSION="\"${VERSION}\"" | |||
|
|
|||
| ifneq ($(or $(findstring $(UNAME),FreeBSD), $(findstring $(UNAME),OpenBSD)),) | |||
| ifneq ($(or $(findstring $(UNAME),FreeBSD), $(findstring $(UNAME),OpenBSD), $(findstring $(UNAME),NetBSD)),) | |||
There was a problem hiding this comment.
Perhaps it's time to just make this look for "BSD" ? dragonfly, miros, trusted, pc, et al?
There was a problem hiding this comment.
My intention was to add the support for my OS and reduce the size of the patchset on Pkgsrc,, not to refactoring foreign code. For Dragonfly, NetBSD, OpenBSD, FreeBSD and many derivates this could work. But not for Bitrig.
Closes #258. Thanks to Daniel Ölschlegel.
|
Thanks for these fixes. I've just pushed a slightly different version of the changes based on some of Karl's suggestions, so I'm going to close this. You can avoid the install long options using |
|
Thanks for integrating this. I just updated pkgsrc-wip/mosquitto to 1.5.1, and was able to drop a lot of patches. Also you can close #252 as a dup of this. |
Closes #258. Thanks to Daniel Ölschlegel.
Signed-Off-By: Daniel Ölschlegel amoibos@gmail.com