Install pkg-config files also for non-CMake builds #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, pkg-config hint files are only installed when CMake is used as build system. However, it is very convenient for programs using libmosquitto to have these files always in place, so let's add it here, too. Signed-off-by: Michael Heimpold <michael.heimpold@i2se.com>
karlp
pushed a commit
to openwrt/packages
that referenced
this pull request
Sep 4, 2018
Install the .pc files to staging directory to help other packages to find the libraries. Since the build does not use CMake, we need to manually install the files and replace two variables using sed. Filed upstream as eclipse/mosquitto#950 Signed-off-by: Michael Heimpold <michael.heimpold@i2se.com> Tested-by: Karl Palsson <karlp@etactica.com>
|
travis failure is about ssl cert validation failures, seems invalid for this PR? |
|
Looks good to me, I'd agree it is a fix. The ssl errors are due to expired test certificates, I've regenerated them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, pkg-config hint files are only installed when CMake is
used as build system. However, it is very convenient for programs using
libmosquitto to have these files always in place, so let's add it
here, too.
Signed-off-by: Michael Heimpold michael.heimpold@i2se.com
From my point of view, this is a fix - YMMV, so I could rebase to develop if desired...