Version Numbers for Milestones/releases must contain qualifier

[cdietrich]

i wonder if there is really no change to have proper version numbers for milestones / releases
(qualifier vs M1)

[dhuebner]

Eclipse DSL Tools

Version: 2019-12 M2 (4.14.0)
Build id: 20191107-0857

[kthoms]

For release artifacts deployed to Maven Central it is better to have artifacts without timestamp qualifier, and with a release qualifier (.M1 for milestones, and none for the GA relase).

For the p2 repository it is better to have timestamp qualifiers. This is especially important when using Tycho, which would rate the ".M1" qualifier higher as a release version without a qualifier.

We have to adjust the build that we still deploy artifacts with the release qualifier, but for the repository build and the artifact metadata we want to stay with the default qualifier mechanism.

One possible way would be to do two builds for releases: First set the version to the release version and run with deploy goal, then reset the changes and build normally with SNAPSHOT/.qualifier and use the resulting repository for p2 repo publishing.

[cdietrich]

have thought we already had this solved with

		<profile>
			<id>release</id>
			<activation>
				<property>
					<name>BUILD_TYPE</name>
					<value>!N</value>
				</property>
			</activation>
			<build>
				<pluginManagement>
					<plugins>
						<plugin>
							<groupId>org.eclipse.tycho</groupId>
							<artifactId>tycho-packaging-plugin</artifactId>
							<configuration>
								<strictVersions>false</strictVersions>
							</configuration>
						</plugin>
					</plugins>
				</pluginManagement>
			</build>
		</profile>

[kthoms]

Though also so. But the build fails when versions do not match

mvn -f maven/org.eclipse.emf.mwe2.parent/pom.xml -Dsign.skip=true -DtestFailureIgnore=false -Dmaven.javadoc.failOnError=false  -Dtycho.localArtifacts=ignore -DBUILD_TYPE=S -Prelease  clean javadoc:aggregate-jar verify


[INFO] --- tycho-p2-plugin:1.5.1:p2-metadata (p2-metadata) @ org.eclipse.emf.mwe2.runtime ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] org.eclipse.emf.mwe2.parent 2.11.1.M1 .............. SUCCESS [  0.070 s]
[INFO] org.eclipse.emf.mwe2.target 2.11.1.M1 .............. SUCCESS [  0.003 s]
[INFO] org.eclipse.emf.mwe2.plugins-parent 2.11.1.M1 ...... SUCCESS [  0.242 s]
[INFO] org.eclipse.emf.mwe.activities 1.5.1-SNAPSHOT ...... SUCCESS [  0.481 s]
[INFO] org.eclipse.emf.mwe2.runtime 2.11.1.M1 ............. FAILURE [  0.181 s]
[INFO] org.eclipse.emf.mwe.core 1.5.1.M1 .................. SUCCESS [  0.042 s]
[INFO] org.eclipse.emf.mwe.ui 1.5.1-SNAPSHOT .............. SUCCESS [  0.031 s]
[INFO] org.eclipse.emf.mwe.ui.simpleEditor 1.5.1-SNAPSHOT . SUCCESS [  0.013 s]
[INFO] org.eclipse.emf.mwe.utils 1.5.1.M1 ................. SUCCESS [  0.013 s]
[INFO] org.eclipse.emf.mwe2.lib 2.11.1.M1 ................. SUCCESS [  0.012 s]
[INFO] org.eclipse.emf.mwe2.language 2.11.1.M1 ............ SUCCESS [  0.040 s]
[INFO] org.eclipse.emf.mwe2.language.ide 2.11.1-SNAPSHOT .. SUCCESS [  0.017 s]
[INFO] org.eclipse.emf.mwe2.language.ui 2.11.1-SNAPSHOT ... SUCCESS [  0.021 s]
[INFO] org.eclipse.emf.mwe2.launch 2.11.1.M1 .............. SUCCESS [  0.014 s]
[INFO] org.eclipse.emf.mwe2.launch.ui 2.11.1-SNAPSHOT ..... SUCCESS [  0.012 s]
[INFO] org.eclipse.emf.mwe.doc 1.5.1-SNAPSHOT ............. SUCCESS [  0.006 s]
[INFO] org.eclipse.emf.mwe2.features-parent 2.11.1.M1 ..... SUCCESS [  0.004 s]
[INFO] org.eclipse.emf.mwe.core.feature 1.5.1.M1 .......... SUCCESS [  0.021 s]
[INFO] org.eclipse.emf.mwe.doc.feature 1.5.1-SNAPSHOT ..... SUCCESS [  0.010 s]
[INFO] org.eclipse.emf.mwe.ui.feature 1.5.1.M1 ............ SUCCESS [  0.021 s]
[INFO] org.eclipse.emf.mwe.sdk 1.5.1.M1 ................... SUCCESS [  0.008 s]
[INFO] org.eclipse.emf.mwe2.runtime.sdk 2.11.1.M1 ......... SUCCESS [  0.007 s]
[INFO] org.eclipse.emf.mwe2.launcher 2.11.1-SNAPSHOT ...... SUCCESS [  0.007 s]
[INFO] org.eclipse.emf.mwe2.language.sdk 2.11.1.M1 ........ SUCCESS [  0.013 s]
[INFO] tests-parent 2.11.1.M1 ............................. SUCCESS [  0.006 s]
[INFO] org.eclipse.emf.mwe.tests 1.5.1.M1 ................. SUCCESS [  0.025 s]
[INFO] org.eclipse.emf.mwe2.language.tests 2.11.1-SNAPSHOT  SUCCESS [  0.020 s]
[INFO] org.eclipse.emf.mwe2.repository 2.11.1.M1 .......... SUCCESS [  0.020 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:12 min
[INFO] Finished at: 2019-11-11T13:14:33+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-p2-plugin:1.5.1:p2-metadata (p2-metadata) on project org.eclipse.emf.mwe2.runtime: Execution p2-metadata of goal org.eclipse.tycho:tycho-p2-plugin:1.5.1:p2-metadata failed.: IllegalArgumentException -> [Help 1]

[kthoms]

The problem does not exist for release builds, where the POM version does not contain a qualifier. This raises only up for milestone builds, which leave .qualifier in manifests, but add a qualifier to the POM version.

Together with @cdietrich we came to the conclusion that for milestone builds the version in manifests have to be replaced by a qualifier as part of the versioning script that replaces the POM versions.

[cdietrich]

@kthoms anything left?