Make _targetTrees field into a local allocated in StackMemoryRegion

The _targetTrees List is used to keep track of TR::TreeTops that are
being processed.  In applying the optimization to requested blocks, the
DeadTreesElimination::process(TR::TreeTop*,TR::TreeTop*) method is
called for all TR::TreeTops in an entire extended basic block;
otherwise it is called for all TR::TreeTops in the method.

After the process method returns, TR:TreeTops in that range will not
need to be visited again during the current application of Dead Trees
Elimination, so there's no need to track them in a _targetTrees field
associated with the optimization.  Instead the field can be made into a
local variable in the process method, with memory allocated in the in
scope StackMemoryRegion object.

The TreeInfo objects that are stored in the List by the
findOrCreateTreeInfo function should be allocated from the same
TR::Region that the List uses for allocation of its nodes to ensure that
their lifetime is as long as that of the containing List object.

compiler/optimizer/DeadTreesElimination.cpp

@@ -73,7 +73,7 @@ static OMR::TreeInfo *findOrCreateTreeInfo(TR::TreeTop *treeTop, List<OMR::TreeI
          return t;
       }
 
-   t = new (comp->trStackMemory()) OMR::TreeInfo(treeTop, 0);
+   t = new (targetTrees->getRegion()) OMR::TreeInfo(treeTop, 0);
    targetTrees->add(t);
    return t;
    }
@@ -433,8 +433,7 @@ TR::Optimization *TR::DeadTreesElimination::create(TR::OptimizationManager *mana
 
 
 TR::DeadTreesElimination::DeadTreesElimination(TR::OptimizationManager *manager)
-   : TR::Optimization(manager),
-     _targetTrees(manager->trMemory())
+   : TR::Optimization(manager)
    {
    _cannotBeEliminated = false;
    _delayedRegStores = false;
@@ -474,8 +473,6 @@ void TR::DeadTreesElimination::prePerformOnBlocks()
    _cannotBeEliminated = false;
    _delayedRegStores = false;
 
-   _targetTrees.deleteAll();
-
    /*
     * Walk through all the blocks to remove trivial dead trees in the following forms:
     *
@@ -759,6 +756,9 @@ static bool treeCanPossiblyBeRemoved(TR::Node *node)
 int32_t TR::DeadTreesElimination::process(TR::TreeTop *startTree, TR::TreeTop *endTree)
    {
    TR::StackMemoryRegion stackRegion(*comp()->trMemory());
+
+   List<OMR::TreeInfo> targetTrees(stackRegion);
+
    LongestPathMap longestPaths(std::less<TR::Node*>(), stackRegion);
 
    typedef TR::typed_allocator<CRAnchor, TR::Region&> CRAnchorAlloc;
@@ -894,7 +894,7 @@ int32_t TR::DeadTreesElimination::process(TR::TreeTop *startTree, TR::TreeTop *e
                   visitCount,
                   comp(),
                   this,
-                  &_targetTrees,
+                  &targetTrees,
                   _cannotBeEliminated,
                   longestPaths);
                }

compiler/optimizer/DeadTreesElimination.hpp

@@ -103,7 +103,6 @@ class DeadTreesElimination : public TR::Optimization
 
    int32_t process(TR::TreeTop *, TR::TreeTop *);
 
-   List<OMR::TreeInfo> _targetTrees;
    bool _cannotBeEliminated;
    bool _delayedRegStores;
    };