-
Notifications
You must be signed in to change notification settings - Fork 393
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Print
initialized
stanza to each file
In order to achieve this, following changes have been made: - Relocate `formatAndOutput(),formatAndOutputV()` to `MM_VerboseBuffer` from `MM_VerboseWriterChain` - In `MM_VerboseHandlerOutput`: - Modified `writeVmArgs` to take a `MM_VerboseBuffer` - Factored out lines for printing `Initialized` stanza in `handleInitialized` - Created `outputInitializedStanza` dedicated to output `Initialized` stanza, which also takes a `MM_VerboseBuffer` - In `outputInitializedStanza`, replaced `handleInitializedInnerStanzas` with `outputInitializedInnerStanza` - In `VerboseHandlerOutput`: - Modified `writeVmArgs` to takes a `MM_VerboseBuffer` - Implement virtual method `outputInitializedInnerStanza()` - Implement `MM_VerboseManager::getVerboseHandlerOutput()` - In `VerboseWriterChain`: - Delete `formatAndOutputV()` - Redirect `formatAndOutput()` to `MM_VerboseBuffer` - Implement `getBuffer()` - In `MM_VerboseWriterFileLoggingBuffered` and `VerboseWriterFileLoggingSynchronous`: - Print `Initialized` stanza on the second file opens (First file is handled by `TRIGGER_J9HOOK_MM_OMR_INITIALIZED`) - In `MM_VerboseWriterFileLogging::endOfCycle`, opens a file right after last file closes to make sure a new `Initialized` stanza is printed in `openFile(...)`. - Changes to generalize handleIniaitzed to work on any provided buffer rather than writer chain specific buffer. This is done to bypass the writer chain with a new buffer during openFile to print stanza specifically for the file being opened. Signed-off-by: Enson Guo <enson.guo@ibm.com>
- Loading branch information
Enson Guo
committed
Nov 20, 2020
1 parent
b406ab2
commit 25d11dd
Showing
13 changed files
with
187 additions
and
132 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.