Skip to content

Commit

Permalink
Remove vrem IL opcode
Browse files Browse the repository at this point in the history
Issue: #6003

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
  • Loading branch information
0xdaryl committed Jun 2, 2021
1 parent 54c2491 commit 4fbff9e
Show file tree
Hide file tree
Showing 21 changed files with 0 additions and 82 deletions.
6 changes: 0 additions & 6 deletions compiler/aarch64/codegen/OMRTreeEvaluator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1430,12 +1430,6 @@ OMR::ARM64::TreeEvaluator::vcomEvaluator(TR::Node *node, TR::CodeGenerator *cg)
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::ARM64::TreeEvaluator::vremEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::ARM64::TreeEvaluator::vshlEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
Expand Down
1 change: 0 additions & 1 deletion compiler/aarch64/codegen/OMRTreeEvaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ class OMR_EXTENSIBLE TreeEvaluator: public OMR::TreeEvaluator
static TR::Register *vdcmpallneEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vdcmpanyneEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vcomEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vremEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vshlEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vushrEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vshrEvaluator(TR::Node *node, TR::CodeGenerator *cg);
Expand Down
6 changes: 0 additions & 6 deletions compiler/arm/codegen/OMRTreeEvaluator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1771,12 +1771,6 @@ OMR::ARM::TreeEvaluator::vdivEvaluator(TR::Node *node, TR::CodeGenerator *cg)
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::ARM::TreeEvaluator::vremEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::ARM::TreeEvaluator::vandEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
Expand Down
1 change: 0 additions & 1 deletion compiler/arm/codegen/OMRTreeEvaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ class OMR_EXTENSIBLE TreeEvaluator: public OMR::TreeEvaluator
static TR::Register *vsubEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vmulEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vdivEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vremEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vandEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vxorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
Expand Down
7 changes: 0 additions & 7 deletions compiler/il/OMRILOps.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1319,13 +1319,6 @@ class ILOpCode
case TR::fconst:
case TR::dconst:
return TR::vsplats;
case TR::brem:
case TR::srem:
case TR::irem:
case TR::lrem:
case TR::frem:
case TR::drem:
return TR::vrem;
case TR::bneg:
case TR::sneg:
case TR::ineg:
Expand Down
16 changes: 0 additions & 16 deletions compiler/il/OMROpcodes.enum
Original file line number Diff line number Diff line change
Expand Up @@ -7091,22 +7091,6 @@ OPCODE_MACRO(\
/* .ifCompareOpCode = */ TR::BadILOp, \
/* .description = vector divide */ \
)
OPCODE_MACRO(\
/* .opcode = */ vrem, \
/* .name = */ "vrem", \
/* .properties1 = */ ILProp1::Rem, \
/* .properties2 = */ ILProp2::ValueNumberShare | ILProp2::SupportedForPRE, \
/* .properties3 = */ 0, \
/* .properties4 = */ 0, \
/* .dataType = */ TR::NoType, \
/* .typeProperties = */ ILTypeProp::Size_16 | ILTypeProp::Vector | ILTypeProp::HasNoDataType, \
/* .childProperties = */ TWO_SAME_CHILD(ILChildProp::UnspecifiedChildType), \
/* .swapChildrenOpCode = */ TR::BadILOp, \
/* .reverseBranchOpCode = */ TR::BadILOp, \
/* .booleanCompareOpCode = */ TR::BadILOp, \
/* .ifCompareOpCode = */ TR::BadILOp, \
/* .description = vector remainder */ \
)
OPCODE_MACRO(\
/* .opcode = */ vand, \
/* .name = */ "vand", \
Expand Down
1 change: 0 additions & 1 deletion compiler/optimizer/OMRSimplifierTable.enum
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,6 @@
#define vsubSimplifierHandler dftSimplifier
#define vmulSimplifierHandler dftSimplifier
#define vdivSimplifierHandler dftSimplifier
#define vremSimplifierHandler dftSimplifier
#define vandSimplifierHandler dftSimplifier
#define vorSimplifierHandler dftSimplifier
#define vxorSimplifierHandler dftSimplifier
Expand Down
1 change: 0 additions & 1 deletion compiler/optimizer/ValuePropagationTable.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,6 @@ TR::Node * constrainLongBitCount(OMR::ValuePropagation *vp, TR::Node *node);
#define vsubVPHandler constrainSubtract
#define vmulVPHandler constrainChildren
#define vdivVPHandler constrainChildren
#define vremVPHandler constrainChildren
#define vandVPHandler constrainChildren
#define vorVPHandler constrainChildren
#define vxorVPHandler constrainChildren
Expand Down
2 changes: 0 additions & 2 deletions compiler/p/codegen/OMRCodeGenerator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1776,8 +1776,6 @@ bool OMR::Power::CodeGenerator::getSupportsOpCodeForAutoSIMD(TR::ILOpCode opcode
return true;
else
return false;
case TR::vrem:
return false;
case TR::vload:
case TR::vloadi:
case TR::vstore:
Expand Down
6 changes: 0 additions & 6 deletions compiler/p/codegen/OMRTreeEvaluator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -909,12 +909,6 @@ OMR::Power::TreeEvaluator::vcomEvaluator(TR::Node *node, TR::CodeGenerator *cg)
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::Power::TreeEvaluator::vremEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::Power::TreeEvaluator::vshlEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
Expand Down
1 change: 0 additions & 1 deletion compiler/p/codegen/OMRTreeEvaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ class OMR_EXTENSIBLE TreeEvaluator: public OMR::TreeEvaluator
static TR::Register *vdcmpallneEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vdcmpanyneEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vcomEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vremEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vshlEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vushrEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vshrEvaluator(TR::Node *node, TR::CodeGenerator *cg);
Expand Down
6 changes: 0 additions & 6 deletions compiler/riscv/codegen/OMRTreeEvaluator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1611,12 +1611,6 @@ OMR::RV::TreeEvaluator::vdivEvaluator(TR::Node *node, TR::CodeGenerator *cg)
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::RV::TreeEvaluator::vremEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::RV::TreeEvaluator::vandEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
Expand Down
1 change: 0 additions & 1 deletion compiler/riscv/codegen/OMRTreeEvaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ class OMR_EXTENSIBLE TreeEvaluator: public OMR::TreeEvaluator
static TR::Register *vsubEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vmulEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vdivEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vremEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vandEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vxorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
Expand Down
6 changes: 0 additions & 6 deletions compiler/x/amd64/codegen/OMRTreeEvaluator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1823,12 +1823,6 @@ OMR::X86::AMD64::TreeEvaluator::vdivEvaluator(TR::Node *node, TR::CodeGenerator
return TR::TreeEvaluator::FloatingPointAndVectorBinaryArithmeticEvaluator(node, cg);
}

TR::Register*
OMR::X86::AMD64::TreeEvaluator::vremEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::X86::AMD64::TreeEvaluator::vandEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
Expand Down
1 change: 0 additions & 1 deletion compiler/x/amd64/codegen/OMRTreeEvaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,6 @@ class OMR_EXTENSIBLE TreeEvaluator: public OMR::X86::TreeEvaluator
static TR::Register *vsubEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vmulEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vdivEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vremEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vandEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vxorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
Expand Down
1 change: 0 additions & 1 deletion compiler/x/codegen/OMRCodeGenerator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1014,7 +1014,6 @@ OMR::X86::CodeGenerator::getSupportsOpCodeForAutoSIMD(TR::ILOpCode opcode, TR::D
else
return false;
case TR::vneg:
case TR::vrem:
return false;
case TR::vxor:
case TR::vor:
Expand Down
6 changes: 0 additions & 6 deletions compiler/x/i386/codegen/OMRTreeEvaluator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1921,12 +1921,6 @@ OMR::X86::I386::TreeEvaluator::vdivEvaluator(TR::Node *node, TR::CodeGenerator *
return TR::TreeEvaluator::FloatingPointAndVectorBinaryArithmeticEvaluator(node, cg);
}

TR::Register*
OMR::X86::I386::TreeEvaluator::vremEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
return TR::TreeEvaluator::unImpOpEvaluator(node, cg);
}

TR::Register*
OMR::X86::I386::TreeEvaluator::vandEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
Expand Down
1 change: 0 additions & 1 deletion compiler/x/i386/codegen/OMRTreeEvaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,6 @@ class OMR_EXTENSIBLE TreeEvaluator: public OMR::X86::TreeEvaluator
static TR::Register *vsubEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vmulEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vdivEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vremEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vandEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vxorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
Expand Down
5 changes: 0 additions & 5 deletions compiler/z/codegen/OMRCodeGenerator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4744,11 +4744,6 @@ bool OMR::Z::CodeGenerator::getSupportsOpCodeForAutoSIMD(TR::ILOpCode opcode, TR
return true;
else
return false;
case TR::vrem:
if (dt == TR::Int32 || dt == TR::Int64)
return true;
else
return false;
case TR::vload:
case TR::vloadi:
case TR::vstore:
Expand Down
6 changes: 0 additions & 6 deletions compiler/z/codegen/OMRTreeEvaluator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16775,12 +16775,6 @@ OMR::Z::TreeEvaluator::vdivEvaluator(TR::Node *node, TR::CodeGenerator *cg)
}
}

TR::Register *
OMR::Z::TreeEvaluator::vremEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
return TR::TreeEvaluator::vDivOrRemHelper(node, cg, false);
}

TR::Register *
OMR::Z::TreeEvaluator::vandEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
Expand Down
1 change: 0 additions & 1 deletion compiler/z/codegen/OMRTreeEvaluator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,6 @@ class OMR_EXTENSIBLE TreeEvaluator: public OMR::TreeEvaluator
static TR::Register *vmulEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vDivOrRemHelper(TR::Node *node, TR::CodeGenerator *cg, bool isDivision);
static TR::Register *vdivEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vremEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vandEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
static TR::Register *vxorEvaluator(TR::Node *node, TR::CodeGenerator *cg);
Expand Down

0 comments on commit 4fbff9e

Please sign in to comment.