Remove the old getSupportsIbyteswap() query

Previously, codegens could declare support for the ibyteswap opcode by overriding a virtual function called getSupportsIbyteswap(). It is now expected that codegens will implement support for all of the byteswap opcodes at the same time. Additionally, this query was never previously used, so it has now been removed. Signed-off-by: Ben Thomas <ben@benthomas.ca>
eclipse · Sep 14, 2020 · 7d68a30 · 7d68a30
1 parent 6df85c1
commit 7d68a30
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 32 deletions.
diff --git a/compiler/codegen/OMRCodeGenerator.cpp b/compiler/codegen/OMRCodeGenerator.cpp
@@ -929,21 +929,6 @@ OMR::CodeGenerator::getSupportsTLE()
    return self()->getSupportsTM();
    }
 
-/** \brief
- *     A query about whether ibyteswap is supported
- *
- *  \return
- *     True if ibyteswap is supported in codegen
- *
- *  \note
- *     Override the query on the platform where ibyteswap is implemented
- */
-bool
-OMR::CodeGenerator::getSupportsIbyteswap()
-   {
-   return false;
-   }
-
 /**
  * Query whether [bsil]bitpermute is supported
  *

diff --git a/compiler/codegen/OMRCodeGenerator.hpp b/compiler/codegen/OMRCodeGenerator.hpp
@@ -1559,8 +1559,6 @@ class OMR_EXTENSIBLE CodeGenerator
 
    virtual bool getSupportsTLE();
 
-   virtual bool getSupportsIbyteswap();
-
    virtual bool getSupportsBitPermute();
 
    bool getSupportsAutoSIMD() { return _flags4.testAny(SupportsAutoSIMD);}

diff --git a/compiler/p/codegen/OMRCodeGenerator.cpp b/compiler/p/codegen/OMRCodeGenerator.cpp
@@ -2397,11 +2397,6 @@ bool OMR::Power::CodeGenerator::is64BitProcessor()
       }
    }
 
-bool OMR::Power::CodeGenerator::getSupportsIbyteswap()
-   {
-   return true;
-   }
-
 bool
 OMR::Power::CodeGenerator::supportsNonHelper(TR::SymbolReferenceTable::CommonNonhelperSymbol symbol)
    {

diff --git a/compiler/p/codegen/OMRCodeGenerator.hpp b/compiler/p/codegen/OMRCodeGenerator.hpp
@@ -186,8 +186,6 @@ class OMR_EXTENSIBLE CodeGenerator : public OMR::CodeGenerator
 
    bool is64BitProcessor();
 
-   bool getSupportsIbyteswap();
-
    void generateBinaryEncodingPrologue(TR_PPCBinaryEncodingData *data);
 
    void beginInstructionSelection();

diff --git a/compiler/x/codegen/OMRCodeGenerator.cpp b/compiler/x/codegen/OMRCodeGenerator.cpp
@@ -1078,12 +1078,6 @@ OMR::X86::CodeGenerator::getSupportsEncodeUtf16BigWithSurrogateTest()
           !self()->comp()->getOption(TR_DisableSIMDUTF16BEEncoder);
    }
 
-bool
-OMR::X86::CodeGenerator::getSupportsIbyteswap()
-   {
-   return true;
-   }
-
 bool
 OMR::X86::CodeGenerator::getSupportsBitPermute()
    {

diff --git a/compiler/x/codegen/OMRCodeGenerator.hpp b/compiler/x/codegen/OMRCodeGenerator.hpp
@@ -362,8 +362,6 @@ class OMR_EXTENSIBLE CodeGenerator : public OMR::CodeGenerator
    bool getSupportsEncodeUtf16LittleWithSurrogateTest();
    bool getSupportsEncodeUtf16BigWithSurrogateTest();
 
-   virtual bool getSupportsIbyteswap();
-
    virtual bool getSupportsBitPermute();
 
    bool supportsNonHelper(TR::SymbolReferenceTable::CommonNonhelperSymbol symbol);