Rename LoadStoreReduction Peephole in Z Codegen

Rename LoadStoreReduction to include the adjective attempt to more clearly describe that this function does not guarantee a load store store sequence will be reduced to MVC. Signed-off-by: Daniel Hong <daniel.hong@live.com>
eclipse · Aug 10, 2018 · a456077 · a456077
1 parent 80d2864
commit a456077
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/compiler/z/codegen/S390Peephole.cpp b/compiler/z/codegen/S390Peephole.cpp
@@ -78,7 +78,7 @@ TR_S390PreRAPeephole::perform()
          {
          case TR::InstOpCode::L:
             {
-            LoadStoreReduction(TR::InstOpCode::ST, 4);
+            attemptLoadStoreReduction(TR::InstOpCode::ST, 4);
             if (comp()->getOption(TR_TraceCG))
                {
                printInst();
@@ -87,7 +87,7 @@ TR_S390PreRAPeephole::perform()
             }
          case TR::InstOpCode::LFH:
             {
-            LoadStoreReduction(TR::InstOpCode::STFH, 4);
+            attemptLoadStoreReduction(TR::InstOpCode::STFH, 4);
             if (comp()->getOption(TR_TraceCG))
                {
                printInst();
@@ -96,7 +96,7 @@ TR_S390PreRAPeephole::perform()
             }
          case TR::InstOpCode::LG:
             {
-            LoadStoreReduction(TR::InstOpCode::STG, 8);
+            attemptLoadStoreReduction(TR::InstOpCode::STG, 8);
             if (comp()->getOption(TR_TraceCG))
                {
                printInst();
@@ -123,7 +123,7 @@ TR_S390PreRAPeephole::perform()
    }
 
 bool
-TR_S390PreRAPeephole::LoadStoreReduction(TR::InstOpCode::Mnemonic storeOpCode, uint16_t size)
+TR_S390PreRAPeephole::attemptLoadStoreReduction(TR::InstOpCode::Mnemonic storeOpCode, uint16_t size)
    {
    if (_cursor->getNext()->getOpCodeValue() == storeOpCode)
       {

diff --git a/compiler/z/codegen/S390Peephole.hpp b/compiler/z/codegen/S390Peephole.hpp
@@ -80,7 +80,7 @@ class TR_S390PreRAPeephole : private TR_S390Peephole
     *  \return
     *     true if the reduction was successful; false otherwise.
     */
-   bool LoadStoreReduction(TR::InstOpCode::Mnemonic storeOpCode, uint16_t size);
+   bool attemptLoadStoreReduction(TR::InstOpCode::Mnemonic storeOpCode, uint16_t size);
    };
 
 class TR_S390PostRAPeephole : private TR_S390Peephole