Fix C4099

``` warning C4099: 'OMR::PersistentAllocatorKit' : type name first seen using 'class' now seen using 'struct' ```
eclipse · Jun 7, 2021 · ab19e76 · ab19e76
1 parent 0f3b2e6
commit ab19e76
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 13 deletions.
diff --git a/compiler/codegen/RegisterDependencyStruct.hpp b/compiler/codegen/RegisterDependencyStruct.hpp
@@ -27,7 +27,7 @@
 namespace TR
 {
 
-struct RegisterDependency : OMR::RegisterDependencyConnector {};
+class RegisterDependency : public OMR::RegisterDependencyConnector {};
 
 }
 

diff --git a/compiler/codegen/Relocation.hpp b/compiler/codegen/Relocation.hpp
@@ -66,8 +66,10 @@ typedef enum
 namespace TR {
 
 /** encapsulates debug information about a relocation record */
-struct RelocationDebugInfo
+class RelocationDebugInfo
    {
+   public:
+
    /** the file name of the code that generated the associated RR*/
    const char* file;
    /** the line number in the file file that created the associated RR*/

diff --git a/compiler/cs2/sparsrbit.h b/compiler/cs2/sparsrbit.h
@@ -311,7 +311,7 @@ class ASparseBitVector : private Allocator {
 
     uint16_t *Indices() const { return fSegment; }
 
-    bool operator==(const struct Segment &s1) const {
+    bool operator==(const Segment &s1) const {
       if (fHighBits != s1.fHighBits) return false;
       if (fNumValues != s1.fNumValues) return false;
 

diff --git a/compiler/env/PersistentAllocatorKit.hpp b/compiler/env/PersistentAllocatorKit.hpp
@@ -36,8 +36,10 @@ namespace TR { using OMR::PersistentAllocatorKit; }
 namespace OMR
 {
 
-struct PersistentAllocatorKit
+class PersistentAllocatorKit
    {
+   public:
+
    PersistentAllocatorKit(TR::RawAllocator rawAllocator) :
       rawAllocator(rawAllocator)
       {

diff --git a/compiler/il/AliasSetInterface.hpp b/compiler/il/AliasSetInterface.hpp
@@ -290,7 +290,8 @@ class TR_AliasSetInterface {
 /*
  * Interface to initialize TR_AliasSetInterface
  */
-struct TR_UseDefAliasSetInterface : public TR_AliasSetInterface<UseDefAliasSet> {
+class TR_UseDefAliasSetInterface : public TR_AliasSetInterface<UseDefAliasSet> {
+   public:
   TR_UseDefAliasSetInterface(TR::SymbolReference *symRef,
                              bool isDirectCall = false,
                              bool includeGCSafePoint = false) :
@@ -305,7 +306,8 @@ struct TR_UseDefAliasSetInterface : public TR_AliasSetInterface<UseDefAliasSet>
     (shares_symbol, symRef, isDirectCall, includeGCSafePoint) {}
 };
 
-struct TR_UseOnlyAliasSetInterface: public TR_AliasSetInterface<UseOnlyAliasSet> {
+class TR_UseOnlyAliasSetInterface: public TR_AliasSetInterface<UseOnlyAliasSet> {
+   public:
   TR_UseOnlyAliasSetInterface(TR::SymbolReference *symRef,
                               bool isDirectCall = false,
                               bool includeGCSafePoint = false) :

diff --git a/compiler/optimizer/CallInfo.hpp b/compiler/optimizer/CallInfo.hpp
@@ -56,7 +56,7 @@ namespace TR { class Method; }
 namespace TR { class ResolvedMethodSymbol; }
 namespace TR { class SymbolReference; }
 namespace TR { class TreeTop; }
-struct TR_CallSite;
+class TR_CallSite;
 struct TR_VirtualGuardSelection;
 
 class TR_CallStack : public TR_Link<TR_CallStack>
@@ -265,8 +265,10 @@ struct TR_CallTarget : public TR_Link<TR_CallTarget>
    TR_CALLSITE_DEFAULT_ALLOC \
    TR_CALLSITE_INHERIT_CONSTRUCTOR_COMMON (EXTENDED,BASE)
 
-struct TR_CallSite : public TR_Link<TR_CallSite>
+class TR_CallSite : public TR_Link<TR_CallSite>
    {
+      public:
+
       TR_ALLOC(TR_Memory::Inliner);
       friend class TR_InlinerTracer;
 

diff --git a/compiler/optimizer/Inliner.hpp b/compiler/optimizer/Inliner.hpp
@@ -88,7 +88,7 @@ namespace TR { class ResolvedMethodSymbol; }
 namespace TR { class Symbol; }
 namespace TR { class SymbolReference; }
 namespace TR { class TreeTop; }
-struct TR_CallSite;
+class TR_CallSite;
 struct TR_CallTarget;
 struct TR_ParameterMapping;
 struct TR_VirtualGuardSelection;

diff --git a/compiler/runtime/OMRCodeCacheManager.hpp b/compiler/runtime/OMRCodeCacheManager.hpp
@@ -44,7 +44,6 @@ namespace TR { class CodeCacheMemorySegment; }
 namespace TR { class CodeGenerator; }
 namespace TR { class Monitor; }
 namespace OMR { class CodeCacheHashEntrySlab; }
-namespace OMR { class FaintCacheBlock; }
 namespace OMR { typedef void CodeCacheTrampolineCode; }
 namespace OMR { class CodeCacheManager; }
 namespace TR { class StaticRelocation; }

diff --git a/fvtest/compilertest/runtime/TestJitConfig.hpp b/fvtest/compilertest/runtime/TestJitConfig.hpp
@@ -31,7 +31,7 @@ namespace TestCompiler { class FrontEnd; }
 // Singleton JitConfig. The only instance of this is TestCompiler::FrontEnd::_jitConfig
 namespace TestCompiler
 {
-struct JitConfig : public TR::JitConfig
+class JitConfig : public TR::JitConfig
    {
    private:
    friend class TR::FEBase<FrontEnd>;

diff --git a/jitbuilder/runtime/JBJitConfig.hpp b/jitbuilder/runtime/JBJitConfig.hpp
@@ -32,9 +32,8 @@ namespace JitBuilder { class FrontEnd; }
 // Singleton JitConfig. The only instance of this is JitBuilder::FrontEnd::_jitConfig
 namespace JitBuilder
 {
-struct JitConfig : public TR::JitConfig
+class JitConfig : public TR::JitConfig
    {
-   private:
    friend class TR::FEBase<FrontEnd>;
    JitConfig() : TR::JitConfig() {}
    };