Skip to content

Commit

Permalink
Make findOrCreateRuntimeHelper boolean parms default to false
Browse files Browse the repository at this point in the history
The vast majority of uses of this API pass in `false` for all three
boolean parameters.  Make that the default value to improve code
readability.

Issue: #5601

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
  • Loading branch information
0xdaryl committed Oct 9, 2020
1 parent cfd5588 commit adc8deb
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions compiler/compile/OMRSymbolReferenceTable.hpp
Expand Up @@ -176,7 +176,7 @@ class SymbolReferenceTable
*/
osrFearPointHelperSymbol,
/** \brief
*
*
* A call with this symbol marks a place where we want/need escape analysis to add heapifications for any stack allocated
* objects. The primary use case is to force escape of all live local objects ahead of a throw to an OSR catch block
* but they may also be inserted to facilitate peeking of methods under HCR or other uses. Calls to this helper should
Expand Down Expand Up @@ -357,16 +357,16 @@ class SymbolReferenceTable
atomicCompareAndSwapReturnValueSymbol,

/** \brief
*
*
* These symbols represent placeholder calls for profiling value which will be lowered into trees later.
*
*
* \code
* call <jProfileValue/jProfileValueWithNullCHK>
* <value to be profiled>
* <table address>
* \endcode
*/
jProfileValueSymbol,
jProfileValueSymbol,
jProfileValueWithNullCHKSymbol,

/** \brief
Expand Down Expand Up @@ -495,7 +495,7 @@ class SymbolReferenceTable
TR::SymbolReference * getSymRef(int32_t i) { return baseArray.element(i); }

TR::SymbolReference * createRuntimeHelper(TR_RuntimeHelper index, bool canGCandReturn, bool canGCandExcept, bool preservesAllRegisters);
TR::SymbolReference * findOrCreateRuntimeHelper(TR_RuntimeHelper index, bool canGCandReturn, bool canGCandExcept, bool preservesAllRegisters);
TR::SymbolReference * findOrCreateRuntimeHelper(TR_RuntimeHelper index, bool canGCandReturn = false, bool canGCandExcept = false, bool preservesAllRegisters = false);

TR::SymbolReference * findOrCreateCodeGenInlinedHelper(CommonNonhelperSymbol index);
TR::SymbolReference * findOrCreateJProfileValuePlaceHolderSymbolRef();
Expand Down

0 comments on commit adc8deb

Please sign in to comment.