Initialize immediate fields for RIE instructions

Failing to default initialize these fields to 0 when a new instruction is generated can result in an ignored byte in the instruction having a non-zero value. This can cause bugs in the future when the byte may no longer be ignored. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
eclipse · Dec 1, 2020 · ba50a0f · ba50a0f
1 parent c041fba
commit ba50a0f
Showing 1 changed file with 32 additions and 6 deletions.
diff --git a/compiler/z/codegen/S390Instruction.hpp b/compiler/z/codegen/S390Instruction.hpp
@@ -3094,7 +3094,11 @@ class S390RIEInstruction : public TR::S390RegInstruction
            : S390RegInstruction(op, n, targetRegister, cg),
              _instructionFormat(RIE_RR),
              _branchDestination(branchDestination),
-             _branchCondition(branchCondition)
+             _branchCondition(branchCondition),
+             _sourceImmediate8(0),
+             _sourceImmediate8One(0),
+             _sourceImmediate8Two(0),
+             _sourceImmediate16(0)
       {
       // note that _targetRegister is registered for use via the
       // S390RegInstruction constructor call
@@ -3113,7 +3117,11 @@ class S390RIEInstruction : public TR::S390RegInstruction
            : S390RegInstruction(op, n, targetRegister, precedingInstruction, cg),
              _instructionFormat(RIE_RR),
              _branchDestination(branchDestination),
-             _branchCondition(branchCondition)
+             _branchCondition(branchCondition),
+             _sourceImmediate8(0),
+             _sourceImmediate8One(0),
+             _sourceImmediate8Two(0),
+             _sourceImmediate16(0)
       {
       // note that _targetRegister is registered for use via the
       // S390RegInstruction constructor call
@@ -3132,7 +3140,10 @@ class S390RIEInstruction : public TR::S390RegInstruction
              _instructionFormat(RIE_RI8),
              _branchDestination(branchDestination),
              _branchCondition(branchCondition),
-             _sourceImmediate8(sourceImmediate)
+             _sourceImmediate8(sourceImmediate),
+             _sourceImmediate8One(0),
+             _sourceImmediate8Two(0),
+             _sourceImmediate16(0)
       {
       // note that _targetRegister is registered for use via the
       // S390RegInstruction constructor call
@@ -3152,7 +3163,10 @@ class S390RIEInstruction : public TR::S390RegInstruction
               _instructionFormat(RIE_RI8),
              _branchDestination(branchDestination),
              _branchCondition(branchCondition),
-             _sourceImmediate8(sourceImmediate)
+             _sourceImmediate8(sourceImmediate),
+             _sourceImmediate8One(0),
+             _sourceImmediate8Two(0),
+             _sourceImmediate16(0)
       {
       // note that _targetRegister is registered for use via the
       // S390RegInstruction constructor call
@@ -3173,7 +3187,8 @@ class S390RIEInstruction : public TR::S390RegInstruction
              _branchCondition(TR::InstOpCode::COND_NOPR),
              _sourceImmediate8(sourceImmediate),
              _sourceImmediate8One(sourceImmediateOne),
-             _sourceImmediate8Two(sourceImmediateTwo)
+             _sourceImmediate8Two(sourceImmediateTwo),
+             _sourceImmediate16(0)
       {
       useSourceRegister(sourceRegister);
       }
@@ -3195,7 +3210,8 @@ class S390RIEInstruction : public TR::S390RegInstruction
              _branchCondition(TR::InstOpCode::COND_NOPR),
              _sourceImmediate8(sourceImmediate),
              _sourceImmediate8One(sourceImmediateOne),
-             _sourceImmediate8Two(sourceImmediateTwo)
+             _sourceImmediate8Two(sourceImmediateTwo),
+             _sourceImmediate16(0)
       {
       // note that _targetRegister is registered for use via the
       // S390RegInstruction constructor call
@@ -3213,6 +3229,9 @@ class S390RIEInstruction : public TR::S390RegInstruction
               _instructionFormat(RIE_RI16A),
              _branchDestination(0),
              _branchCondition(branchCondition),
+             _sourceImmediate8(0),
+             _sourceImmediate8One(0),
+             _sourceImmediate8Two(0),
              _sourceImmediate16(sourceImmediate)
       {
       // Note that _targetRegister is registered for use via the S390RegInstruction constructor call
@@ -3232,6 +3251,9 @@ class S390RIEInstruction : public TR::S390RegInstruction
               _instructionFormat(RIE_RI16A),
              _branchDestination(0),
              _branchCondition(branchCondition),
+             _sourceImmediate8(0),
+             _sourceImmediate8One(0),
+             _sourceImmediate8Two(0),
              _sourceImmediate16(sourceImmediate)
       {
       if (isTrap())
@@ -3255,6 +3277,8 @@ class S390RIEInstruction : public TR::S390RegInstruction
         _branchDestination(0),
         _branchCondition(TR::InstOpCode::COND_NOPR),
         _sourceImmediate8(0),
+        _sourceImmediate8One(0),
+        _sourceImmediate8Two(0),
         _sourceImmediate16(sourceImmediate)
       {
       // note that _targetRegister is registered for use via the
@@ -3274,6 +3298,8 @@ class S390RIEInstruction : public TR::S390RegInstruction
         _branchDestination(0),
         _branchCondition(TR::InstOpCode::COND_NOPR),
         _sourceImmediate8(0),
+        _sourceImmediate8One(0),
+        _sourceImmediate8Two(0),
         _sourceImmediate16(sourceImmediate)
       {
       // note that _targetRegister is registered for use via the