Skip to content

Commit

Permalink
Enable MaxMin tests for Float/Double on LoZ, and disable them on zOS
Browse files Browse the repository at this point in the history
- Enables the Float & Double MaxMin tests on Linux on Z
- Disables them on z/OS, since TRIL parser cannot handle NaN values

Closes: #5157

Signed-off-by: Sarwat Shaheen <sarwat.shaheen@yahoo.com>
  • Loading branch information
sarwat12 committed Feb 13, 2024
1 parent 3f8a0e7 commit d763955
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions fvtest/compilertriltest/MaxMinTest.cpp
Expand Up @@ -203,8 +203,7 @@ TEST_P(FloatMaxMin, UsingConst) {
auto param = TRTest::to_struct(GetParam());

if (std::isnan(param.lhs) || std::isnan(param.rhs)) {
SKIP_ON_S390(KnownBug) << "fmin / fmax returns wrong value for NaN on Z (see issue #5157)";
SKIP_ON_S390X(KnownBug) << "fmin / fmax returns wrong value for NaN on Z (see issue #5157)";
SKIP_ON_ZOS(KnownBug) << "fmin / fmax returns wrong value for NaN on Z (see issue #5157)";
}

char inputTrees[1024] = {0};
Expand Down Expand Up @@ -238,8 +237,7 @@ TEST_P(FloatMaxMin, UsingLoadParam) {
auto param = TRTest::to_struct(GetParam());

if (std::isnan(param.lhs) || std::isnan(param.rhs)) {
SKIP_ON_S390(KnownBug) << "fmin / fmax returns wrong value for NaN on Z (see issue #5157)";
SKIP_ON_S390X(KnownBug) << "fmin / fmax returns wrong value for NaN on Z (see issue #5157)";
SKIP_ON_ZOS(KnownBug) << "fmin / fmax returns wrong value for NaN on Z (see issue #5157)";
}

char inputTrees[1024] = {0};
Expand Down Expand Up @@ -281,8 +279,7 @@ TEST_P(DoubleMaxMin, UsingConst) {
auto param = TRTest::to_struct(GetParam());

if (std::isnan(param.lhs) || std::isnan(param.rhs)) {
SKIP_ON_S390(KnownBug) << "dmin / dmax returns wrong value for NaN on Z (see issue #5157)";
SKIP_ON_S390X(KnownBug) << "dmin / dmax returns wrong value for NaN on Z (see issue #5157)";
SKIP_ON_ZOS(KnownBug) << "dmin / dmax returns wrong value for NaN on Z (see issue #5157)";
}

char inputTrees[1024] = {0};
Expand Down Expand Up @@ -316,9 +313,7 @@ TEST_P(DoubleMaxMin, UsingLoadParam) {
auto param = TRTest::to_struct(GetParam());

if (std::isnan(param.lhs) || std::isnan(param.rhs)) {
SKIP_ON_S390(KnownBug) << "dmin / dmax returns wrong value for NaN on Z (see issue #5157)";
SKIP_ON_S390X(KnownBug) << "dmin / dmax returns wrong value for NaN on Z (see issue #5157)";

SKIP_ON_ZOS(KnownBug) << "dmin / dmax returns wrong value for NaN on Z (see issue #5157)";
}

char inputTrees[1024] = {0};
Expand Down

0 comments on commit d763955

Please sign in to comment.