Merge pull request #3061 from 0dvictor/unimpl

Remove unused unimplemented evaluator on X86
eclipse · Oct 18, 2018 · ea548a6 · ea548a6
2 parents bed3f9f + 07ed9e8
commit ea548a6
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 24 deletions.
diff --git a/compiler/x/amd64/codegen/TreeEvaluatorTable.hpp b/compiler/x/amd64/codegen/TreeEvaluatorTable.hpp
@@ -639,7 +639,7 @@
    TR::TreeEvaluator::arraycopyEvaluator,                              // TR::arraycopy
    TR::TreeEvaluator::arraysetEvaluator,                               // TR::arrayset
    TR::TreeEvaluator::arraytranslateEvaluator,                         // TR::arraytranslate
-   TR::TreeEvaluator::arraytranslateAndTestEvaluator,                  // TR::arraytranslateAndTest
+   TR::TreeEvaluator::unImpOpEvaluator,                                // TR::arraytranslateAndTest
    TR::TreeEvaluator::badILOpEvaluator,                                // TR::long2String
    TR::TreeEvaluator::badILOpEvaluator,                                // TR::bitOpMem
    TR::TreeEvaluator::badILOpEvaluator,                                // TR::bitOpMemND

diff --git a/compiler/x/codegen/OMRTreeEvaluator.cpp b/compiler/x/codegen/OMRTreeEvaluator.cpp
@@ -2363,25 +2363,6 @@ TR::Register *OMR::X86::TreeEvaluator::arraycopyEvaluator(TR::Node *node, TR::Co
    return NULL;
    }
 
-TR::Register *OMR::X86::TreeEvaluator::reverseLoadEvaluator(TR::Node *node, TR::CodeGenerator *cg)
-   {
-   TR_ASSERT(0, "reverseLoad not implemented yet for this platform");
-   return NULL;
-   }
-
-TR::Register *OMR::X86::TreeEvaluator::reverseStoreEvaluator(TR::Node *node, TR::CodeGenerator *cg)
-   {
-   TR_ASSERT(0, "reverseStore not implemented yet for this platform");
-   return NULL;
-   }
-
-
-TR::Register *OMR::X86::TreeEvaluator::arraytranslateAndTestEvaluator(TR::Node *node, TR::CodeGenerator *cg)
-   {
-   TR_ASSERT(0, "arraytranslateAndTest not implemented yet for this platform");
-   return NULL;
-   }
-
 TR::Register *OMR::X86::TreeEvaluator::arraytranslateEvaluator(TR::Node *node, TR::CodeGenerator *cg)
    {
    //

diff --git a/compiler/x/codegen/OMRTreeEvaluator.hpp b/compiler/x/codegen/OMRTreeEvaluator.hpp
@@ -227,9 +227,6 @@ class OMR_EXTENSIBLE TreeEvaluator: public OMR::TreeEvaluator
    static TR::Register *passThroughEvaluator(TR::Node *node, TR::CodeGenerator *cg);
    static TR::Register *arraysetEvaluator(TR::Node *node, TR::CodeGenerator *cg);
    static TR::Register *arraytranslateEvaluator(TR::Node *node, TR::CodeGenerator *cg);
-   static TR::Register *arraytranslateAndTestEvaluator(TR::Node *node, TR::CodeGenerator *cg);
-   static TR::Register *reverseLoadEvaluator(TR::Node *node, TR::CodeGenerator *cg);
-   static TR::Register *reverseStoreEvaluator(TR::Node *node, TR::CodeGenerator *cg);
    static TR::Register *arraycmpEvaluator(TR::Node *node, TR::CodeGenerator *cg);
    static TR::Register *arraycopyEvaluator(TR::Node *node, TR::CodeGenerator *cg);
    static TR::Register *overflowCHKEvaluator(TR::Node *node, TR::CodeGenerator *cg);

diff --git a/compiler/x/i386/codegen/TreeEvaluatorTable.hpp b/compiler/x/i386/codegen/TreeEvaluatorTable.hpp
@@ -639,7 +639,7 @@
    TR::TreeEvaluator::arraycopyEvaluator,                              // TR::arraycopy
    TR::TreeEvaluator::arraysetEvaluator,                               // TR::arrayset
    TR::TreeEvaluator::arraytranslateEvaluator,                         // TR::arraytranslate
-   TR::TreeEvaluator::arraytranslateAndTestEvaluator,                  // TR::arraytranslateAndTest
+   TR::TreeEvaluator::unImpOpEvaluator,                                // TR::arraytranslateAndTest
    TR::TreeEvaluator::badILOpEvaluator,                                // TR::long2String
    TR::TreeEvaluator::badILOpEvaluator,                                // TR::bitOpMem
    TR::TreeEvaluator::badILOpEvaluator,                                // TR::bitOpMemND