Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spelling of "initialize" consistent #2486

Closed
0xdaryl opened this issue Apr 20, 2018 · 0 comments
Closed

Make spelling of "initialize" consistent #2486

0xdaryl opened this issue Apr 20, 2018 · 0 comments

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Apr 20, 2018

Of all uses of the word "initialize" (and its variants) in the compiler codebase (identifiers, comments, etc.), 2.4% of them use the British spelling "initialise". Change these to match the other 97.6% that spell it as "initialize".

This will make searching easier as one does not have to check for alternate spellings (yes, I'm grumpy because I was fooled by one of these recently).

This should generally be a straightforward change (only 26 uses in the compiler), however, please be careful with initialiseAOTRelocationHeader and initialiseRelocation as they will require downstream OpenJ9 changes too. One way of staging this would be to rename in OMR, create "initialise" versions in OMR that simply redirect to the "initialize" versions, merge your PR, make and merge the corresponding change in OpenJ9, and then remove the "initialise" versions in OMR.

This issue only covers the compiler codebase. There are other inconsistent uses throughout the rest of OMR that could/should be fixed up as well but are not tracked by this issue.

fjeremic added a commit to fjeremic/omr that referenced this issue Apr 20, 2018
This will make searching easier as one does not have to check for
alternate spellings.

Fixes: eclipse#2486

Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
fjeremic added a commit to fjeremic/omr that referenced this issue Apr 20, 2018
This will make searching easier as one does not have to check for
alternate spellings.

Fixes: eclipse#2486

Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
fjeremic added a commit to fjeremic/omr that referenced this issue Jun 6, 2018
This will make searching easier as one does not have to check for
alternate spellings.

Fixes: eclipse#2486

Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
fjeremic added a commit to fjeremic/omr that referenced this issue Jun 6, 2018
This will make searching easier as one does not have to check for
alternate spellings.

Fixes: eclipse#2486

Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant