Remove dead code from SwitchAnalyzer

[0xdaryl]

While investigating a loadaddr issue, I discovered a dead path in SwitchAnalyzer::addTableBlock. It looks to be a remnant of earlier refactoring.

omr/compiler/optimizer/SwitchAnalyzer.cpp

Line 1260 in b8634d5

TR::SymbolReference *branchTableSymRef = NULL;

branchTableSymRef and branchTable are never changed from their initial values. Remove and fold code assuming both are 0.

[mrSeoD]

@0xdaryl Hey! I love to help on this.
Just to clarify, you would like both "branchTableSymRef" and "branchTable" to be removed from the code and their values "NULL" and "0" are replaced into wherever the variables were written?
Thanks!

[0xdaryl]

Hi... Thanks for volunteering to help. By "fold code" I mean simplifying the code assuming the values of those variables will always be "0". For example, the if (branchTable) will always evaluate to false since branchTable is always 0, which means the code under the if can be deleted because it cannot ever be executed.

[mrSeoD]

@0xdaryl Got it! I will make changes and create the pull request!