Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omrtime API for process time #7201

Closed
tajila opened this issue Dec 12, 2023 · 3 comments
Closed

Add omrtime API for process time #7201

tajila opened this issue Dec 12, 2023 · 3 comments

Comments

@tajila
Copy link
Contributor

tajila commented Dec 12, 2023

See eclipse-openj9/openj9#18598 for motivation

On linux process start time can be found in /proc/[pid]/stat.

On windows one can use GetProcessTimes

More research needs to be done for mac, aix and z/os.

@singh264
Copy link
Contributor

@tajila I would like to address this GitHub issue.

singh264 added a commit to singh264/omr that referenced this issue Dec 29, 2023
Add an API to get the process start time on linux,
windows, osx, aix and z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Dec 29, 2023
Add an API to get the process start time on linux,
windows, osx, aix and z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Dec 29, 2023
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 2, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 2, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 2, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 2, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 4, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 4, 2024
- Simplified the include statements in si.cpp.
- Added a comment to clarify usage of pid = UINTPTR_MAX,
  if (0 == pid) { and exit(0) in si.cpp.
- Removed the function description in
  port/unix/omrsysinfo.c and port/win32/omrsysinfo.c.
- Adjusted the function description in
  port/common/omrsysinfo.c.
- Added a description and a passing condition to the
  documentation of the tests.
- Adjusted GetProcessorStartTimeOfExistingProcessTest to
  not run on z/TPF.
- Reused OMRTIME_NANOSECONDS_PER_SECOND that is in
  omrport.h.
- Reused I_32_MAX that is in omrcomp.h.
- Adjusted the macros to be like #define
  OMRPORT_SYSINFO_*.
- Added tracepoints for the error messages.
- Adjusted the usages of omrsysinfo_process_exists.
- Defined structs with typedef.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 8, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 8, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 8, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 10, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 10, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 10, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 11, 2024
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
singh264 added a commit to singh264/omr that referenced this issue Jan 11, 2024
Adjust omrsysinfo_get_process_start_time traces to avoid
casting.

Issue: eclipse#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
@singh264
Copy link
Contributor

singh264 commented Jan 22, 2024

This issue can be closed and it was addressed by:

@babsingh
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants