Document Exception Semantics #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2017 10:06
Signed-off-by: Irwin D'Souza <dsouzai@ca.ibm.com>
Update the code to use TR::Compilation::failCompilation instead of explicitly throwing an exception since the failCompilation method provides a debugging message that helps determine where an exception was thrown from. Signed-off-by: Irwin D'Souza <dsouzai@ca.ibm.com>
fjeremic
reviewed
Oct 2, 2017
|
Documentation itself looks good to me - covers the exceptions and their use cases nicely. |
|
genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1726. This PR also includes some minor cleanup, namely using the
TR::Compilation::failCompilationmethod instead of explicitly throwing an exception.