Allow OMRPORT_OMRSIG_SUPPORT to be enabled and disabled globally #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes will allow a consumer of OMR to enable and disable OMRPORT_OMRSIG_SUPPORT via the configure files. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
|
@dnakamura can you verify if I covered all CMake dependencies? |
|
@dnakamura ping |
|
LGTM |
| @@ -161,6 +161,7 @@ set(OMR_PORT_CAN_RESERVE_SPECIFIC_ADDRESS ON CACHE BOOL "TODO: Document") | |||
| set(OMR_PORT_NUMA_SUPPORT OFF CACHE BOOL "TODO: Document") | |||
| set(OMR_PORT_ALLOCATE_TOP_DOWN OFF CACHE BOOL "TODO: Document") | |||
| set(OMR_PORT_ZOS_CEEHDLRSUPPORT OFF CACHE BOOL "TODO: Document") | |||
| set(OMRPORT_OMRSIG_SUPPORT OFF CACHE BOOL "TODO: Document") | |||
There was a problem hiding this comment.
Should this be defaulted to OFF or ON? @dnakamura didn't you think this should just be on all of the time?
There was a problem hiding this comment.
by default, OMRPORT_OMRSIG_SUPPORT is turned off in OMR. Currently, OpenJ9 only enables OMRPORT_OMRSIG_SUPPORT while building DDR. in OMR, i feel that OMRPORT_OMRSIG_SUPPORT should be disabled by default. if a consumer of OMR wants signal chaining, then they should enable it while glueing OMR.
|
@genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will allow a consumer of OMR to enable and disable
OMRPORT_OMRSIG_SUPPORT via the configure files.
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com