CMake: Search for windows message compiler #3677
Conversation
|
Actually, looking at the appveyor build, I see it failed due to: @dnakamura Is this a path setup issue? |
Don't just assume that its on the path Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
|
@DanHeidinga The issue was that when cmake was run, |
|
@genie-omr build win xlinux |
| set(kit_dir "${kit_dir}/bin/x86") | ||
| endif() | ||
| # find the message compiler | ||
| find_program(CMAKE_MC_COMPILER mc.exe HINTS "${kit_dir}") |
There was a problem hiding this comment.
Could the kit_dir be some call that a user could specify if they have it installed in a random location that they do not want to have on their path?
There was a problem hiding this comment.
no matter where they install it, the location should still be stored in the registry (which is where we pull kit_dir from). If for whatever reason its not in the registry you could still specify -DCMAKE_MC_COMPILER=xxxx on the command line.
Don't just assume that its on the path
Signed-off-by: Devin Nakamura devinn@ca.ibm.com