Create Test Stubs for OMR Socket API #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohaley
requested review from
charliegracie,
mstoodle,
rwy7 and
youngar
as code owners
caohaley
force-pushed
the
socketTest
branch
2 times, most recently
from
7556427
to
7ec29fa
Compare
caohaley
changed the title
Created test stubs in omrsockTest.cpp, in test set PortSockTest in Port Tests -Created 2 helper function stubs, one for setting up a server socket, one for setting up a client socket. These functions will be called multiple times, in multiple tests. -Created 4 test stubs in PortSockTest. -Will need to add other tests during implementation. Issue: eclipse#4102 Signed-off-by: Haley Cao <haleycao88@hotmail.com>
caohaley
changed the title
|
Ready for Review. |
rwy7
changed the title
rwy7
suggested changes
Oct 30, 2019
babsingh
requested changes
Oct 30, 2019
rwy7
reviewed
Oct 31, 2019
caohaley
force-pushed
the
socketTest
branch
4 times, most recently
from
d7b2fe9
to
8e4b134
Compare
|
I have done the fixes and committed them in a new commit |
|
@rwy0717 Could you please run the automated tests instead? I tried to run on Jenkins but it failed both times from a JIT compilation error, Sorry about that. |
|
@genie-omr build all |
babsingh
reviewed
Nov 1, 2019
Accept suggested and requested changes - Deletion of the test entry and exit reports - Grammar fixes - Added more descriptive test names Issue: eclipse#4102 Co-Authored-By: Babneet Singh <sbabneet@ca.ibm.com> Signed-off-by: Haley Cao <haleycao88@hotmail.com>
|
@genie-omr build all |
|
@genie-omr build aix |
rwy7
approved these changes
Nov 6, 2019
|
Test failure not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created test stubs in omrsockTest.cpp, in test set PortSockTest in Port Tests
-Created 2 helper function stubs, one for setting up a server socket, one
for setting up a client socket. These functions will be called multiple times,
in multiple tests.
-Created 4 test stubs in PortSockTest.
-Will need to add other tests during implementation.
Issue: #4102
Signed-off-by: Haley Cao haleycao88@hotmail.com