Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change realTimeGC field to an internal option #4945

Merged
merged 1 commit into from Mar 24, 2020

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Mar 17, 2020

This change is to support the JITServer to send the option flag from the client to the Compilation object at the server.

Related to issue eclipse-openj9/openj9#8707

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change is to support the JITServer to send
the option flag from the client to the
Compilation object at the server.

Related to eclipse-openj9/openj9#8707

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo added a commit to a7ehuo/openj9 that referenced this pull request Mar 20, 2020
This change is to support the JITServer receiving
the realTimeGC config setting from the client for
per compilation.

Also implemented the server version of
`getCellSizeForSizeClass() and `getObjectSizeClass()`
which were missing and are triggered when realTimeGC is true.

Related to eclipse/omr#4945

Fixes: eclipse-openj9#8707

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo changed the title WIP: Change realTimeGC field to an internal option Change realTimeGC field to an internal option Mar 23, 2020
@a7ehuo a7ehuo marked this pull request as ready for review March 23, 2020 14:03
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Mar 23, 2020

@Leonardo2718 Could you help review this one? Thanks!

Copy link
Contributor

@Leonardo2718 Leonardo2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Leonardo2718
Copy link
Contributor

@genie-omr build all

@Leonardo2718
Copy link
Contributor

@genie-omr build zos

1 similar comment
@Leonardo2718
Copy link
Contributor

@genie-omr build zos

@Leonardo2718 Leonardo2718 merged commit 1862ec4 into eclipse:master Mar 24, 2020
@a7ehuo a7ehuo deleted the fixRealTimeGC-omr-2 branch October 12, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants