New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change realTimeGC field to an internal option #4945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
force-pushed
the
fixRealTimeGC-omr-2
branch
from
March 18, 2020 14:37
81d2a11
to
e45fbbb
Compare
mpirvu
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change is to support the JITServer to send the option flag from the client to the Compilation object at the server. Related to eclipse-openj9/openj9#8707 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
fixRealTimeGC-omr-2
branch
from
March 19, 2020 20:46
e45fbbb
to
7d3bc55
Compare
a7ehuo
added a commit
to a7ehuo/openj9
that referenced
this pull request
Mar 20, 2020
This change is to support the JITServer receiving the realTimeGC config setting from the client for per compilation. Also implemented the server version of `getCellSizeForSizeClass() and `getObjectSizeClass()` which were missing and are triggered when realTimeGC is true. Related to eclipse/omr#4945 Fixes: eclipse-openj9#8707 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
changed the title
WIP: Change realTimeGC field to an internal option
Change realTimeGC field to an internal option
Mar 23, 2020
@Leonardo2718 Could you help review this one? Thanks! |
Leonardo2718
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@genie-omr build all |
@genie-omr build zos |
1 similar comment
@genie-omr build zos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to support the JITServer to send the option flag from the client to the Compilation object at the server.
Related to issue eclipse-openj9/openj9#8707
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com