Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed dependency list overflow assert to fatal #4962

Merged
merged 2 commits into from Mar 26, 2020
Merged

Changed dependency list overflow assert to fatal #4962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
248cce6
Changed dependency list overflow assert to fatal
VermaSh Mar 20, 2020
5c808aa
Removed compilation exception
VermaSh Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 2 additions & 16 deletions compiler/z/codegen/OMRRegisterDependency.hpp
View file
Open in desktop
Expand Up @@ -362,14 +362,7 @@ class RegisterDependencyConditions: public OMR::RegisterDependencyConditions
// dont add dependencies if reg is real register
if (vr && vr->getRealRegister()!=NULL) return;

if (_addCursorForPre >= _numPreConditions)
{
// Printf added so it triggers some output even in prod build.
// If this failure is triggered in a prod build, you might
// not get a SEGV nor any meaningful error msg.
TR_ASSERT(0,"ERROR: addPreCondition list overflow\n");
_cg->comp()->failCompilation<TR::CompilationException>("addPreCondition list overflow, abort compilation\n");
}
TR_ASSERT_FATAL(_addCursorForPre < _numPreConditions,"addPreCondition list overflow. addCursorForPre(%d), numPreConditions(%d), virtual register name(%s) and pointer(%p)\n",_addCursorForPre, _numPreConditions,vr->getRegisterName(_cg->comp()),vr);
_preConditions->setDependencyInfo(_addCursorForPre++, vr, rr, flag);
}

Expand Down Expand Up @@ -405,14 +398,7 @@ class RegisterDependencyConditions: public OMR::RegisterDependencyConditions

// dont add dependencies if reg is real register
if (vr && vr->getRealRegister()!=NULL) return;
if (_addCursorForPost >= _numPostConditions)
{
// Printf added so it triggers some output even in prod build.
// If this failure is triggered in a prod build, you might
// not get a SEGV nor any meaningful error msg.
TR_ASSERT(0,"ERROR: addPostCondition list overflow\n");
_cg->comp()->failCompilation<TR::CompilationException>("addPostCondition list overflow, abort compilation\n");
}
TR_ASSERT_FATAL(_addCursorForPost < _numPostConditions,"addPostCondition list overflow. addCursorForPost(%d), numPostConditions(%d), virtual register name(%s) and pointer(%p)\n",_addCursorForPost, _numPostConditions,vr->getRegisterName(_cg->comp()),vr);
_postConditions->setDependencyInfo(_addCursorForPost++, vr, rr, flag);
}

Expand Down