Use TR_BitVector instead of CS2::ABitVector in TR_InterferenceGraph #5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbhuiyan
force-pushed
the
interference-graph
branch
from
5c9e4f2
to
03b55f1
Compare
|
@genie-omr build all |
|
@fjeremic I just discovered that I missed some changes required for the debug build. I will notify you when that is fixed. |
Some of the largest symbols in the compiler obj files originates from TR_InterferenceGraph resulting from its use of CS2::ABitVector, while providing no real benefits in terms of capabilities or performance. Use of CS2::ABitVector has been replaced with TR_BitVector in TR_InterferenceGraph, which results in significant reduction in the size of the Compiler component's obj files, whether it is part of a standalone OMR build or part of a downstream project. Signed-off-by: Nazim Bhuiyan <nubhuiyan@ibm.com>
nbhuiyan
force-pushed
the
interference-graph
branch
from
03b55f1
to
6d806b9
Compare
|
@fjeremic , fixed now. |
|
@genie-omr build all |
fjeremic
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the largest symbols in the compiler obj files originates
from TR_InterferenceGraph resulting from its use of
CS2::ABitVector, while providing no real benefits in terms
of capabilities or performance. Use of CS2::ABitVector has been
replaced with TR_BitVector in TR_InterferenceGraph, which results
in significant reduction in the size of the Compiler component's
obj files, whether it is part of a standalone OMR build or part of
a downstream project.
With this fairly small change, compiler builds will see a 41.5 KB
reduction in the on-disk size of the obj files.
Signed-off-by: Nazim Bhuiyan nubhuiyan@ibm.com