Convert concurrent-mark-end to gc-op in GMP concurrent increment
#5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gza060625
force-pushed
the
concurrent-mark-end
branch
from
031d4e7
to
d9d377d
Compare
gza060625
force-pushed
the
concurrent-mark-end
branch
3 times, most recently
from
85a3acb
to
d8e5860
Compare
gza060625
force-pushed
the
concurrent-mark-end
branch
2 times, most recently
from
b690b15
to
634a4ea
Compare
RSalman
suggested changes
Jan 14, 2021
RSalman
reviewed
Jan 15, 2021
eclipse-openj9/openj9#11239 - Replace `concurrent-mark-end` in `concurrent-end` with `gc-op` - moved `terminationReason` as one attribute to `concurrent-end` stanza for both concurrent marking and concurrent scavenging - delete warning for reporting termination reason in scavenging (rare case) - report concurrent marking duration `timems` in gc-op - Add new API to get termination reason `MM_VerboseHandlerOutput::getReasonForTermination` - Consolidate `handleConcurrentGCOpEnd` into `handleConcurrentEndInternal` Signed-off-by: Enson Guo <enson.guo@ibm.com>
gza060625
force-pushed
the
concurrent-mark-end
branch
from
d4d3962
to
2b18099
Compare
gza060625
changed the title
concurrent-mark-end to gc-op in GMP concurrent incrementconcurrent-mark-end to gc-op in GMP concurrent increment
gza060625
requested review from
charliegracie,
rwy7 and
youngar
as code owners
|
@fjeremic This PR is ready, please further review. Thanks! |
|
@genie-omr build all |
|
x86 tests did not finish due to us switchin the Jenkins farm, but we get coverage from Azure. I'm confident enough to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-openj9/openj9#11239
concurrent-mark-endinconcurrent-endwithgc-opterminationReasonas one attribute toconcurrent-endstanzafor both concurrent marking and concurrent scavenging
timemsin gc-opMM_VerboseHandlerOutput::getReasonForTerminationhandleConcurrentGCOpEndintohandleConcurrentEndInternal