AArch64: Vector add tril test #5874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvee-unb
requested review from
0xdaryl,
fjeremic,
knn-k and
Leonardo2718
as code owners
alvee-unb
changed the title
knn-k
reviewed
Mar 31, 2021
knn-k
reviewed
Mar 31, 2021
knn-k
reviewed
Mar 31, 2021
|
AArch64 passes the 4 tests of vector addition in my local environment. |
This commit adds test-cases for the vector add implementation on relevant tril test- VectorTest for the following vector data-types- - VectorInt8 - VectorInt16 - VectorFloat Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
|
@genie-omr build all |
knn-k
approved these changes
Apr 1, 2021
|
@alvee-unb @knn-k : please see Power CI failures introduced by these tests -> https://ci.eclipse.org/omr/job/PullRequest-linux_ppc-64_le_gcc/3063 I think the VectorInt8 tests need to be excluded for Power if it doesn't have such support. |
|
Ah, I didn't notice that when I merged this PR. |
|
The test passes on x86 platform. I will exclude this for Power platform. |
|
#5901 fixed the test failures on Power. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds test-cases for the vector add implementation on
relevant tril test- VectorTest for the following vector data-types-