Re-enable omrport tests on all platforms #6533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
requested review from
charliegracie,
youngar,
rwy7 and
mstoodle
as code owners
|
jenkins build all |
|
jenkins build all |
github-actions
bot
added
arch:power
build / configure
ci
comp:port
comp:test
os:aix
labels
Failing tests are disabled and tracked via: - eclipse#6542 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
changed the title
|
jenkins build all |
|
jenkins build zos |
|
@dsouzai Can you help with reviewing/merging this PR? |
babsingh
commented
Jun 1, 2022
Comment on lines
+192
to
+196
| set(EXCLUDE_LIST "${EXCLUDE_LIST}-PortFileTest2.file_test20") | ||
| set(EXCLUDE_LIST "${EXCLUDE_LIST}:PortFileTest2.file_test21") | ||
| set(EXCLUDE_LIST "${EXCLUDE_LIST}:PortFileTest2.file_test22") | ||
| set(EXCLUDE_LIST "${EXCLUDE_LIST}:PortFileTest2.file_test23") | ||
| set(EXCLUDE_LIST "${EXCLUDE_LIST}:PortFileTest2.file_test24") |
There was a problem hiding this comment.
Each if/elseif block corresponds to a platform/spec in order to keep the exclude-list easy to read. This leads to duplicates. Avoiding the duplicates will lead to extra logic, which will make it difficult to comprehend the exclude-list.
dsouzai
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing tests are disabled, and they are tracked via: #6542.
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com