Add OMR Option to disable merging of OSR Guards #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gita-omr / @jdmpapin Can I please get your review on this change? I removed the use of environment option to disable merging of OSR guards and added OMR Option so that we can set it through JIT command line option so that it would be easier to test Vector API expansion changes through automated testing. |
|
LGTM |
gita-omr
approved these changes
Jun 13, 2022
|
Jenkins build all |
0xdaryl
reviewed
Jun 15, 2022
compiler/control/OMROptions.cpp
Outdated
| @@ -475,6 +475,7 @@ TR::OptionTable OMR::Options::_jitOptions[] = { | |||
| #ifdef J9_PROJECT_SPECIFIC | |||
| {"disableOSRGuardRemoval", "O\tdisable OSR guard removal", TR::Options::disableOptimization, osrGuardRemoval, 0, "P"}, | |||
| #endif | |||
| {"disableOSRGuardsMerging", "O\tdisable Merging of OSR guards", SET_OPTION_BIT(TR_DisableOSRGuardsMerging), "F"}, | |||
There was a problem hiding this comment.
To keep the naming consistent with the other OSR guard option on the line above, can you name this "disableOSRGuardMerging" instead?
There was a problem hiding this comment.
Previously we had an environment option to disable merging of OSR guards which was needed to allow VectorAPIExpansion to scalarize or vectorize Vector API intrinsics on X and Z. Replacing an enviromentment option to OMR Option to make it easier to set it for automated testing. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
|
Jenkins build all |
0xdaryl
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had an environment option to disable merging of OSR guards
which was needed to allow VectorAPIExpansion to scalarize or vectorize
Vector API intrinsics on X and Z. Replacing an enviromentment option to
OMR Option to make it easier to set it for automated testing.
Signed-off-by: Rahil Shah rahil@ca.ibm.com