Fix an assert in OMR::Power::TreeEvaluator::s2iEvaluator() #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The s2iEvaluator uses a isLoad() test when deciding between a simple sign extend or generating a load sequence. The isLoad() test returns true for both LoadVar and LoadConst cases and therefore we can get into the load sequence when handling a sconst node child which results in an assert. This PR will change isLoad() to isLoadVar() so that the sconst case will use the simple sign extend path. Signed-off-by: Kevin Langman <langman@ca.ibm.com>
|
Jenkins build plinux,aix |
0xdaryl
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The s2iEvaluator uses a isLoad() test when deciding between a simple
sign extend or generating a load sequence. The isLoad() test returns
true for both LoadVar and LoadConst cases and therefore we can get
into the load sequence when handling a sconst node child which results
in an assert. This PR will change isLoad() to isLoadVar() so that
the sconst case will use the simple sign extend path.
Signed-off-by: Kevin Langman langman@ca.ibm.com