Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for arrayset evaluator #6943

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add unit tests for arrayset evaluator #6943

wants to merge 1 commit into from

Conversation

Akira1Saitoh
Copy link
Contributor

This commit adds unit tests of arrayset evaluator to ArrayTest test suite.

@Akira1Saitoh Akira1Saitoh mentioned this pull request Apr 6, 2023
Closed
@knn-k
Copy link
Contributor

knn-k commented Apr 6, 2023

Jenkins build aarch64,amac,aix,plinux,zlinux,zos

@knn-k
Copy link
Contributor

knn-k commented Apr 7, 2023

Jenkins build win,zos

@Akira1Saitoh
Copy link
Contributor Author

Disabled testcases that validate arrayset with constant length on x86.

@knn-k
Copy link
Contributor

knn-k commented Apr 14, 2023

Jenkins build all

@knn-k
Copy link
Contributor

knn-k commented Apr 17, 2023

Jenkins build riscv

1 similar comment
@knn-k
Copy link
Contributor

knn-k commented May 29, 2023

Jenkins build riscv

@knn-k
Copy link
Contributor

knn-k commented May 30, 2023 •
edited

RISC-V test failed in ArraysetTest/Int8ArraysetTest:

[2023-05-30T00:25:22.468Z] 29/30 Test #29: comptest ..........................Child killed***Exception: 1563.84 sec

BradleyWood
BradleyWood reviewed Aug 29, 2023
View reviewed changes
fvtest/compilertriltest/ArrayTest.cpp Outdated
TEST_P(type##ArraysetTest, UsingConstLenConstVal) { \
SKIP_ON_ARM(MissingImplementation); \
SKIP_ON_RISCV(MissingImplementation); \
SKIP_ON_HAMMER(KnownBug) << "The AMD64 code generator sets wrong value (see issue #6964)"; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue fixed

fvtest/compilertriltest/ArrayTest.cpp Outdated
TEST_P(type##ArraysetTest, UsingConstLen) { \
SKIP_ON_ARM(MissingImplementation); \
SKIP_ON_RISCV(MissingImplementation); \
SKIP_ON_HAMMER(KnownBug) << "The AMD64 code generator sets wrong value (see issue #6964)"; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue fixed

fvtest/compilertriltest/ArrayTest.cpp Outdated
TEST_P(type##ArraysetUnalignedTest, UsingConstLen) { \
SKIP_ON_ARM(MissingImplementation); \
SKIP_ON_RISCV(MissingImplementation); \
SKIP_ON_HAMMER(KnownBug) << "The AMD64 code generator sets wrong value (see issue #6964)"; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue fixed

@Akira1Saitoh
Copy link
Contributor Author

Enabled tests on x86.

@knn-k
Copy link
Contributor

knn-k commented Aug 30, 2023

Jenkins build all

@knn-k
Copy link
Contributor

knn-k commented Aug 30, 2023

RISC-V failed in the same way as before:

[2023-08-30T03:56:44.857Z] 29: Missing Implementation: Skipping test: Us
[2023-08-30T03:56:44.857Z] 29/30 Test #29: comptest ..........................Child killed***Exception: 1920.73 sec

@Akira1Saitoh
Add unit tests for arrayset evaluator
9781c06 
This commit adds unit tests of arrayset evaluator to ArrayTest test suite.

Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
@Akira1Saitoh
Copy link
Contributor Author

Rebased to resolve conflict.

@knn-k
Copy link
Contributor

knn-k commented Apr 1, 2024

Jenkins build all

@knn-k
Copy link
Contributor

knn-k commented Apr 1, 2024

RISC-V failed during ArraysetTest/Int8ArraysetTest in the same way as before:

[2024-04-01T07:05:58.950Z] 29: Missing Implementation: Skipping test: UsingConstLenConstVal/995
[2024-04-01T07:05:58.950Z] 29:     
[2024-04-01T07:05:58.950Z] 29: Missing Implementation
[2024-04-01T07:05:58.950Z] 29/30 Test #29: comptest ..........................Child killed***Exception: 1599.68 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradleyWood BradleyWood BradleyWood left review comments

@fjeremic fjeremic Awaiting requested review from fjeremic fjeremic will be requested when the pull request is marked ready for review fjeremic is a code owner

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl will be requested when the pull request is marked ready for review 0xdaryl is a code owner

Assignees
No one assigned
Labels
comp:test comp:tril
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Akira1Saitoh @knn-k @BradleyWood