Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct loop limit adjustment for bound check versioning #7174

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Correct loop limit adjustment for bound check versioning #7174

wants to merge 1 commit into from

Conversation

BradleyWood
Copy link
Member

@BradleyWood BradleyWood commented Nov 8, 2023 •
edited

@BradleyWood
Correct loop limit adjustment for bound check versioning
66c0ee3 
Issue: #17045

Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
@0xdaryl
Copy link
Contributor

0xdaryl commented Nov 9, 2023

@jdmpapin : would you mind reviewing this please?

@BradleyWood
Copy link
Member Author

I have some doubts as to what happens if you have a loop counting down with a >= compare. I tried modifying a test case to count down and it seemed to perform normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysun-omr vijaysun-omr Awaiting requested review from vijaysun-omr vijaysun-omr will be requested when the pull request is marked ready for review vijaysun-omr is a code owner

Assignees
No one assigned
Labels
comp:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BradleyWood @0xdaryl