DDR: support DWARF version 5 #7272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested review from
charliegracie,
mstoodle and
0xdaryl
as code owners
|
Put in draft mode while I verify that build environments provide |
* generalize getConstValue() and use it in more places * add (implicit) support for DW_FORM_implicit_const Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
In an earlier state of this there was an explicit use of A sufficiently recent version of @babsingh Would you mind reviewing this, please? |
|
jenkins build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getConstValue()and use it in more placesDW_FORM_implicit_constThis change, together with a modification of OpenJ9 to stop avoiding DWARF version 5, allowed me to build OpenJ9 for Linux on s390x and x86_64.
This may fix #6135.