Print assertion failure to log and flush even if DEBUG is not defined #7280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TR_ASSERT_FATAL() could fail in any build, and in particular in builds without DEBUG. Previously, if such a failure occurred with tracing enabled, the process would crash without printing the failure to the log, and more importantly, without flushing previously written trace output, which was confusing and impeded debugging.
|
Jenkins build all |
0xdaryl
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR_ASSERT_FATAL()could fail in any build, and in particular in builds withoutDEBUG. Previously, if such a failure occurred with tracing enabled, the process would crash without printing the failure to the log, and more importantly, without flushing previously written trace output, which was confusing and impeded debugging.