Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explanation for enableGuardedCountingRecompilation #7287

Merged
merged 1 commit into from Mar 21, 2024
Merged

Fix explanation for enableGuardedCountingRecompilation #7287

merged 1 commit into from Mar 21, 2024

Conversation

jmesyou
Copy link
Contributor

@jmesyou jmesyou commented Mar 21, 2024

No description provided.

@jmesyou jmesyou requested a review from dsouzai as a code owner March 21, 2024 14:39
@dsouzai dsouzai self-assigned this Mar 21, 2024
@dsouzai
Copy link
Member

dsouzai commented Mar 21, 2024

jenkins build all

dsouzai
dsouzai requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna risk sounding pendantic, but I suggested some changes to improve the clarity a tad.

compiler/control/OMROptions.cpp Outdated Show resolved Hide resolved
compiler/control/OMROptions.cpp Outdated Show resolved Hide resolved
@jmesyou
Fix explanation for GuardedCountingRecompilation
770f422 
Signed-off-by: James You <james.you@protonmail.com>
@jmesyou jmesyou requested a review from dsouzai March 21, 2024 15:39
@dsouzai
Copy link
Member

dsouzai commented Mar 21, 2024

jenkins build all

@dsouzai
Copy link
Member

dsouzai commented Mar 21, 2024

Not really sure about the riscv test failure:

12:27:13  29: �[0;32m[  PASSED  ] �[m156911 tests.
12:27:13  29: �[0;32m[  ALL TESTS PASSED  ] 
12:27:56  29: �[m
12:27:56  29/30 Test #29: comptest ..........................Child killed***Exception: 1455.81 sec

but this PR's changes can't impact that.

macos failure due to #7181

@dsouzai dsouzai merged commit 622e8ea into eclipse:master Mar 21, 2024
15 of 18 checks passed
@jmesyou jmesyou deleted the docs/options/gcr branch March 21, 2024 17:19
@jmesyou jmesyou mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsouzai dsouzai dsouzai approved these changes

Assignees

@dsouzai dsouzai

Labels
comp:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmesyou @dsouzai