CMake: fix empty string warnings #7288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@babsingh Could you please have a look at this? |
|
jenkins build all |
|
Something is still wrong: In draft mode while I sort that out. |
Prior to this change, numerous warnings are issued by cmake:
CMake Warning:
Ignoring empty string ("") provided on the command line.
Rework how the decision to use 'cygpath -w' is made: Provide
USE_PATH_TOOL to GenerateStub.cmake so it can behave as desired.
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
I think the problem here was that the test in was failing because |
keithc-ca
force-pushed
the
ddr_path_tool
branch
from
0bd1949
to
1691da5
Compare
keithc-ca
changed the title
|
Tested internally. |
|
jenkins build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, numerous warnings are issued by cmake:
Rework how the decision to use
cygpath -wis made: ProvideUSE_PATH_TOOLtoGenerateStub.cmakeso it can behave as desired.This has the same goal as #7283, but without the problem (eclipse-openj9/openj9#19210) it introduced.