Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo AIXPPCX -> AIXPPC #7292

Merged
merged 1 commit into from Mar 25, 2024
Merged

Fix typo AIXPPCX -> AIXPPC #7292

merged 1 commit into from Mar 25, 2024

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Mar 25, 2024

On AIX, this typo disables code that prevents upcall_handler from
collecting thread data when upcall_handler is unregistered. Collecting
data after upcall_handler is unregistered might cause corrupt memory
to be passed through siginfo and lead to crashes.

More context:
On AIX, a signal can can be unavailable to sigpending/sigwait but
not yet have been delivered to a thread. As a result, it is not
guaranteed that SIG_SUSPEND won't be delivered after upcall_handler
is unregistered.

On AIX, this typo disables code that prevents upcall_handler from
collecting thread data when upcall_handler is unregistered. Collecting
data after upcall_handler is unregistered might cause corrupt memory
to be passed through siginfo and lead to crashes.

More context:
On AIX, a signal can can be unavailable to sigpending/sigwait but
not yet have been delivered to a thread. As a result, it is not
guaranteed that SIG_SUSPEND won't be delivered after upcall_handler
is unregistered.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

jenkins build all

@babsingh
Copy link
Contributor Author

@babsingh
Copy link
Contributor Author

@dsouzai Can you please review and merge these changes?

@dsouzai dsouzai merged commit 6c6d638 into eclipse:master Mar 25, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants