Upgrade pugixml 1.5 to 1.8 #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdaryl
force-pushed
the
pugixml
branch
2 times, most recently
from
b096f48
to
96386f7
Compare
pugixml 1.8 was chosen because it can still be built using the same build files as pugixml 1.5. Miscellanous modifications to pugixml.cpp were made for EBCDIC support and for snprintf compatibility with modern build compilers. pugixml 1.5 is deleted from OMR. The main motivation for this upgrade is to simplify the license vetting process with the Eclipse Foundation. However, it is also useful to maintain currency with newer pugixml releases. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
|
Jenkins build all |
|
macOS failure is #7181. |
|
@mstoodle : please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pugixml 1.8 was chosen because it can still be built using the same build files as pugixml 1.5.
Miscellanous modifications to pugixml.cpp were made for EBCDIC support and for snprintf compatibility with modern build compilers.
pugixml 1.5 is deleted from OMR.
The main motivation for this upgrade is to simplify the license vetting process with the Eclipse Foundation. However, it is also useful to maintain currency with newer pugixml releases.