AArch64: Stop generating instruction for adding 0 #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build aarch64,amac |
|
Jenkins build aarch64,amac |
|
Jenkins build aarch64,amac |
|
See #7181 for the failure on x86 macOS. |
This commit changes addConstant32() and addConstant64() for AArch64 so that they don't generate instructions when the value to be added is 0. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
Jenkins build aarch64,amac |
|
Again, the test failure on x86-64 macOS is with TestJitBuilderAPIGenerator. See #7181. |
|
I changed the return type of these two functions from |
0xdaryl
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes addConstant32() and addConstant64() for AArch64 so that they don't generate instructions when the value to be added is 0.