Fix omrgenerate_ieat_dump.s assembly instruction to load 64 bit #7339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the load register instructions was meant to be loading the 64 bit address over which was not apparent while compiling with XLC. The problem manifested itself as a segmentation fault with Open XL, and this addresses that issue while keeping XLC working the same way. Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@ibm.com>
|
jenkins build zos |
babsingh
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Open XL bring up of OMR, a segmentation fault was seen while running the
omrporttesttarget.One of the load register instructions was meant to be loading the 64-bit address over which was not apparent while compiling with XLC. The problem manifested itself as a segmentation fault with Open XL, and this addresses that issue while keeping XLC working the same way.